-
Notifications
You must be signed in to change notification settings - Fork 341
feat(docs): add layout.api-reference-layout to docs.yml #17377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # yaml-language-server: $schema=../../../../../fern-changes-yml.schema.json | ||
|
|
||
| - summary: | | ||
| Add a `layout.api-reference-layout` option to docs.yml. Set it to `cards` to render | ||
| nested API reference fields as bordered cards, or `indented` (the default) to render | ||
| each nested level as an indented branch with a connector line and a path breadcrumb. | ||
| type: feat |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
...cli/configuration/src/docs-yml/schemas/sdk/api/resources/docs/types/ApiReferenceLayout.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| // This file was auto-generated by Fern from our API Definition. | ||
|
|
||
| export const ApiReferenceLayout = { | ||
| Indented: "indented", | ||
| Cards: "cards", | ||
| } as const; | ||
| export type ApiReferenceLayout = (typeof ApiReferenceLayout)[keyof typeof ApiReferenceLayout]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
...uration/src/docs-yml/schemas/sdk/serialization/resources/docs/types/ApiReferenceLayout.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| // This file was auto-generated by Fern from our API Definition. | ||
|
|
||
| import type * as FernDocsConfig from "../../../../api/index.js"; | ||
| import * as core from "../../../../core/index.js"; | ||
| import type * as serializers from "../../../index.js"; | ||
|
|
||
| export const ApiReferenceLayout: core.serialization.Schema< | ||
| serializers.ApiReferenceLayout.Raw, | ||
| FernDocsConfig.ApiReferenceLayout | ||
| > = core.serialization.enum_(["indented", "cards"]); | ||
|
|
||
| export declare namespace ApiReferenceLayout { | ||
| export type Raw = "indented" | "cards"; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔵 suggestion
This is now the third field smuggled through the
as unknown as ParsedDocsConfiguration["layout"]cast, which means a typo inapiReferenceLayout(or a mismatch with the eventual FDR field name) compiles silently and fails only at runtime in the platform. Consider a narrow local type (e.g.type PendingLayoutFields = { changelogLayout?: ...; apiReferenceLayout?: ...; showNavAvailabilityBadges?: boolean }) spread into the cast so at least the pending keys are typed, and confirm the downstream docs-registration path forwards unknown layout keys rather than mapping fields explicitly.