-
Notifications
You must be signed in to change notification settings - Fork 339
chore(deps): bump reqwest-sse from 0.1.0 to 0.2.0 in /generators/cli/sdk #17486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dependabot
wants to merge
1
commit into
main
Choose a base branch
from
dependabot/cargo/generators/cli/sdk/reqwest-sse-0.2.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Locked dependency version no longer matches what the generated CLI code requires, breaking reproducible builds
The pinned server-sent-events library is moved to a new major line (
reqwest-sse = "0.2"atgenerators/cli/sdk/Cargo.toml:110) even though the generated CLI code still asks for the previous line (0.1), so the shipped lock file no longer contains a version the generated output can use.Impact: Generated CLIs that use streaming can no longer be built or audited in locked/offline mode, silently disabling the dependency-auditing guarantee this dependency exists to provide.
Version-closure mismatch between cli/sdk lock and the Rust SDK generator
This dependency is declared solely to pin the generated model/SDK crates' dependency closure into the shipped
Cargo.lock(see the comments atgenerators/cli/sdk/Cargo.toml:88-109, which state "Versions must match what the model generator emits ... Any package they need that is absent from this lock makes the generated output failcargo build --locked...cargo audit").The Rust SDK generator still emits
reqwest-sse = { version: "0.1", optional: true }(generators/rust/base/src/context/AbstractRustGeneratorContext.ts:212) andreqwest = { version: "0.12", ... }(AbstractRustGeneratorContext.ts:114-115). In Cargo semver, the requirement"0.1"means>=0.1.0, <0.2.0, which0.2.0does not satisfy. The lock was regenerated toreqwest-sse0.2.0(generators/cli/sdk/Cargo.lock:1817-1818), so the generated crate's^0.1requirement can no longer be resolved from the shipped lock — defeating the lock-closure purpose.Secondly,
reqwest-sse0.2.0depends onreqwest 0.13.4(generators/cli/sdk/Cargo.lock:1823), while the SSE template code callsresponse.events()through theEventSourcetrait on areqwest0.12Response(generators/rust/base/src/asIs/sse_stream.rs:5,:155-158). The 0.2 trait is implemented against reqwest 0.13 types, so the generated SSE code would not compile against reqwest 0.12.The bump should be coordinated:
AbstractRustGeneratorContext.ts(and the reqwest version /sse_stream.rsusage) must be updated together with this pin, or the pin should stay at0.1.Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.