fix(cli): resolve the basepath of a preview when deleting by --id - #17517
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
fix(cli): resolve the basepath of a preview when deleting by --id#17517devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Linear ticket: Refs
fern docs preview delete --id <id>built the preview hostname from the org + ID and sent that to FDR. FDR keys a docs site on hostname + basepath, so for a preview published under a basepath (acme-preview-abc.docs.buildwithfern.com/docs) nothing was deleted — the DB rows survived, the S3 assets (deleted by hostname prefix) did not, and the CLI still printed "Successfully deleted" with exit code 0.The ID now resolves to the URL FDR actually stores, by looking the deployment up in the same listing
fern docs preview listuses (listAllDocsUrls({ preview: true }), org-scoped server-side) and keeping itsbasePath.Changes Made
resolvePreviewUrlFromIdlooks up the preview by hostname and returnsdomain + basePath; root previews behave exactly as before.Fails loudly instead of silently deleting the wrong thing: no match → "No preview deployment found for ID ..." pointing at
fern docs preview list; a host serving several basepaths → lists them and asks for the full URL.Login now happens before ID resolution (the lookup needs the token).
toPreviewUrlextracted fromlistDocsPreviewso the list and delete paths build the URL identically.Updated README.md generator (if applicable)
Testing
findPreviewsForHostnamecovering basepath preservation, root previews, multi-basepath hosts, no match, case-insensitive hostnames, and pagingpnpm --filter @fern-api/cli exec vitest run src/commands/docs-previewpasses,pnpm turbo run compile --filter @fern-api/cliandpnpm lint:biomecleanDepends on nothing, but pairs with fern-api/fern-platform#14208, which stops a deleted site from continuing to serve its statically-cached HTML.
Link to Devin session: https://app.devin.ai/sessions/8b998ca2cd694ebca3ac34947854002c