Skip to content

PS1 epic #412: cleanup pipeline (#428), golden validation (#817), CLI (#431), rigid animation (#429)#844

Merged
fernandotonon merged 5 commits into
masterfrom
feat/ps1-remaining-issues-412
Jul 11, 2026
Merged

PS1 epic #412: cleanup pipeline (#428), golden validation (#817), CLI (#431), rigid animation (#429)#844
fernandotonon merged 5 commits into
masterfrom
feat/ps1-remaining-issues-412

PS1 #429: add Ps1AnimationExtractor.cpp to the tests/ PS1 source list

f0c75c2
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jul 11, 2026 in 6m 30s

Annotations

Check warning on line 94 in src/PS1/runtime/Ps1AnimationExtractor.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the redundant type with "auto".

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9P_GB5fVNoVDTzNKYt&open=AZ9P_GB5fVNoVDTzNKYt&pullRequest=844

Check warning on line 134 in src/PS1/runtime/Ps1AnimationExtractor.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declaration shadows a local variable "i" in the outer scope.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9P_GB4fVNoVDTzNKYq&open=AZ9P_GB4fVNoVDTzNKYq&pullRequest=844

Check warning on line 872 in src/PS1/runtime/PS1RipMeshBuilder.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::array" or "std::vector" instead of a C-style array.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9P_GD3fVNoVDTzNKYw&open=AZ9P_GD3fVNoVDTzNKYw&pullRequest=844

Check failure on line 917 in src/ScanEngine.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9P_GNdfVNoVDTzNKY8&open=AZ9P_GNdfVNoVDTzNKY8&pullRequest=844

Check failure on line 950 in src/ScanEngine.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

const_cast removing const qualification from the type of a pointer may lead to an undefined behaviour.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9P_GNdfVNoVDTzNKZG&open=AZ9P_GNdfVNoVDTzNKZG&pullRequest=844

Check failure on line 10205 in src/CLIPipeline.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture the required scope variables.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9P_GKifVNoVDTzNKY3&open=AZ9P_GKifVNoVDTzNKY3&pullRequest=844

Check failure on line 660 in src/PS1/runtime/MeshReconstructor.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9P_F7zfVNoVDTzNKYk&open=AZ9P_F7zfVNoVDTzNKYk&pullRequest=844

Check warning on line 79 in src/PS1/runtime/Ps1AnimationExtractor.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

implicit conversion loses integer precision: 'qsizetype' (aka 'long long') to 'const int'

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9P_GB4fVNoVDTzNKYn&open=AZ9P_GB4fVNoVDTzNKYn&pullRequest=844

Check failure on line 10001 in src/CLIPipeline.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 117 to the 25 allowed.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9P_GKifVNoVDTzNKY1&open=AZ9P_GKifVNoVDTzNKY1&pullRequest=844

Check warning on line 44 in src/PS1/runtime/Ps1AnimationExtractor.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::array" or "std::vector" instead of a C-style array.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9P_GECfVNoVDTzNKYz&open=AZ9P_GECfVNoVDTzNKYz&pullRequest=844

Check warning on line 946 in src/ScanEngine.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::array" or "std::vector" instead of a C-style array.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9P_GNdfVNoVDTzNKZF&open=AZ9P_GNdfVNoVDTzNKZF&pullRequest=844

Check warning on line 53 in src/PS1/runtime/Ps1AnimationExtractor.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::array" or "std::vector" instead of a C-style array.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9P_GB5fVNoVDTzNKYs&open=AZ9P_GB5fVNoVDTzNKYs&pullRequest=844

Check warning on line 654 in src/PS1/runtime/MeshReconstructor.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "v2" inside the if statement.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9P_F7zfVNoVDTzNKYj&open=AZ9P_F7zfVNoVDTzNKYj&pullRequest=844

Check warning on line 873 in src/PS1/runtime/PS1RipMeshBuilder.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::array" or "std::vector" instead of a C-style array.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9P_GD3fVNoVDTzNKYx&open=AZ9P_GD3fVNoVDTzNKYx&pullRequest=844

Check failure on line 943 in src/ScanEngine.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9P_GNdfVNoVDTzNKY-&open=AZ9P_GNdfVNoVDTzNKY-&pullRequest=844

Check warning on line 10238 in src/CLIPipeline.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Pass this large object by reference to const.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9P_GKifVNoVDTzNKY5&open=AZ9P_GKifVNoVDTzNKY5&pullRequest=844

Check warning on line 110 in src/PS1/runtime/Ps1AnimationExtractor.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "of" inside the if statement.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9P_GB4fVNoVDTzNKYo&open=AZ9P_GB4fVNoVDTzNKYo&pullRequest=844

Check warning on line 10236 in src/CLIPipeline.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 17 parameters, which is greater than the 7 authorized.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9P_GKifVNoVDTzNKY6&open=AZ9P_GKifVNoVDTzNKY6&pullRequest=844

Check warning on line 940 in src/ScanEngine.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define each identifier in a dedicated statement.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9P_GNdfVNoVDTzNKZC&open=AZ9P_GNdfVNoVDTzNKZC&pullRequest=844

Check warning on line 1889 in src/ScanEngine.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the commented out code.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9P_GNdfVNoVDTzNKZI&open=AZ9P_GNdfVNoVDTzNKZI&pullRequest=844

Check warning on line 43 in src/PS1/runtime/Ps1AnimationExtractor.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::array" or "std::vector" instead of a C-style array.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9P_GECfVNoVDTzNKYy&open=AZ9P_GECfVNoVDTzNKYy&pullRequest=844

Check warning on line 1877 in src/ScanEngine.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the commented out code.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9P_GNdfVNoVDTzNKZH&open=AZ9P_GNdfVNoVDTzNKZH&pullRequest=844

Check failure on line 10236 in src/CLIPipeline.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture the required scope variables.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9P_GKifVNoVDTzNKY4&open=AZ9P_GKifVNoVDTzNKY4&pullRequest=844

Check warning on line 938 in src/ScanEngine.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define each identifier in a dedicated statement.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9P_GNdfVNoVDTzNKZA&open=AZ9P_GNdfVNoVDTzNKZA&pullRequest=844

Check warning on line 661 in src/PS1/runtime/MeshReconstructor.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

implicit conversion loses integer precision: 'qsizetype' (aka 'long long') to 'int'

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9P_F7zfVNoVDTzNKYi&open=AZ9P_F7zfVNoVDTzNKYi&pullRequest=844