Skip to content

t2m v2 (epic #837): twist transport, foot pinning, flow-matching model#904

Merged
fernandotonon merged 27 commits into
masterfrom
feat/t2m-epic-837
Jul 20, 2026
Merged

t2m v2 (epic #837): twist transport, foot pinning, flow-matching model#904
fernandotonon merged 27 commits into
masterfrom
feat/t2m-epic-837

fix(anim): address PR #904 review comments (#837)

dc6cc2f
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jul 20, 2026 in 3m 31s

Annotations

Check warning on line 4404 in src/MCPServer.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function should be declared "const".

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9hZ0H_M9Kp0ePROePd&open=AZ9hZ0H_M9Kp0ePROePd&pullRequest=904

Check warning on line 1597 in src/AnimationMerger.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this variable a pointer-to-const. The current type of "footTrk" is "class Ogre::NodeAnimationTrack *".

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9hZ0JyM9Kp0ePROePu&open=AZ9hZ0JyM9Kp0ePROePu&pullRequest=904

Check warning on line 1948 in src/AnimationMerger.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::array" or "std::vector" instead of a C-style array.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9hZ0JyM9Kp0ePROeP0&open=AZ9hZ0JyM9Kp0ePROeP0&pullRequest=904

Check warning on line 328 in src/MotionGenerator.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define each identifier in a dedicated statement.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9-pi9h2552VlYdOyxd&open=AZ9-pi9h2552VlYdOyxd&pullRequest=904

Check warning on line 4450 in src/MCPServer.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this variable a pointer-to-const. The current type of "node" is "class Ogre::SceneNode *".

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9hZ0H_M9Kp0ePROePf&open=AZ9hZ0H_M9Kp0ePROePf&pullRequest=904

Check warning on line 110 in src/FootContact.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

implicit conversion from 'int' to 'float' may lose precision

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9hZ0OJM9Kp0ePROeP6&open=AZ9hZ0OJM9Kp0ePROeP6&pullRequest=904

Check warning on line 2026 in src/AnimationMerger.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define each identifier in a dedicated statement.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9iZwLLxi9ITghewBhP&open=AZ9iZwLLxi9ITghewBhP&pullRequest=904

Check warning on line 43 in src/FootContact.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the redundant type with "auto".

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9hZ0OJM9Kp0ePROeP8&open=AZ9hZ0OJM9Kp0ePROeP8&pullRequest=904

Check warning on line 1595 in src/AnimationMerger.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this variable a pointer-to-const. The current type of "thighTrk" is "class Ogre::NodeAnimationTrack *".

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9hZ0JyM9Kp0ePROePs&open=AZ9hZ0JyM9Kp0ePROePs&pullRequest=904

Check warning on line 5830 in src/MCPServer.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Catch a more specific exception instead of a generic one.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9hZ0H_M9Kp0ePROePg&open=AZ9hZ0H_M9Kp0ePROePg&pullRequest=904

Check warning on line 111 in src/FootContact.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

implicit conversion from 'int' to 'float' may lose precision

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9hZ0OJM9Kp0ePROeP7&open=AZ9hZ0OJM9Kp0ePROeP7&pullRequest=904

Check failure on line 2056 in src/AnimationMerger.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9hZ0JyM9Kp0ePROePz&open=AZ9hZ0JyM9Kp0ePROePz&pullRequest=904

Check warning on line 1970 in src/AnimationMerger.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::array" or "std::vector" instead of a C-style array.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9-pij-2552VlYdOyxZ&open=AZ9-pij-2552VlYdOyxZ&pullRequest=904

Check warning on line 1596 in src/AnimationMerger.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this variable a pointer-to-const. The current type of "shinTrk" is "class Ogre::NodeAnimationTrack *".

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9hZ0JyM9Kp0ePROePt&open=AZ9hZ0JyM9Kp0ePROePt&pullRequest=904

Check warning on line 4418 in src/MCPServer.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this variable a pointer-to-const. The current type of "entity" is "class Ogre::Entity *".

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9hZ0H_M9Kp0ePROePe&open=AZ9hZ0H_M9Kp0ePROePe&pullRequest=904

Check warning on line 1610 in src/AnimationMerger.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this loop so that it is less error-prone.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9-pij-2552VlYdOyxX&open=AZ9-pij-2552VlYdOyxX&pullRequest=904

Check warning on line 2104 in src/AnimationMerger.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "th" inside the if statement.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9hZ0JyM9Kp0ePROePw&open=AZ9hZ0JyM9Kp0ePROePw&pullRequest=904

Check warning on line 4263 in src/MCPServer.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "smoothFps" inside the if statement.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9iZv-rxi9ITghewBhL&open=AZ9iZv-rxi9ITghewBhL&pullRequest=904

Check failure on line 2047 in src/AnimationMerger.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9hZ0JyM9Kp0ePROePy&open=AZ9hZ0JyM9Kp0ePROePy&pullRequest=904

Check warning on line 1653 in src/AnimationMerger.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the redundant type with "auto".

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9hZ0JyM9Kp0ePROePv&open=AZ9hZ0JyM9Kp0ePROePv&pullRequest=904

Check warning on line 2024 in src/AnimationMerger.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::array" or "std::vector" instead of a C-style array.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9iZwLLxi9ITghewBhO&open=AZ9iZwLLxi9ITghewBhO&pullRequest=904

Check warning on line 1517 in src/AnimationMerger.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::array" or "std::vector" instead of a C-style array.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9hZ0JyM9Kp0ePROePq&open=AZ9hZ0JyM9Kp0ePROePq&pullRequest=904

Check warning on line 413 in src/MotionGenerator.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define each identifier in a dedicated statement.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9-pi9h2552VlYdOyxe&open=AZ9-pi9h2552VlYdOyxe&pullRequest=904

Check failure on line 2080 in src/CLIPipeline.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9hZ0MxM9Kp0ePROeP1&open=AZ9hZ0MxM9Kp0ePROeP1&pullRequest=904

Check failure on line 4199 in src/MCPServer.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements.

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ9hZ0H_M9Kp0ePROePc&open=AZ9hZ0H_M9Kp0ePROePc&pullRequest=904