Skip to content

ci: pin the fmt-check nightly toolchain to a fixed date#60

Merged
nh13 merged 1 commit into
mainfrom
ci/pin-fmt-nightly
Jun 24, 2026
Merged

ci: pin the fmt-check nightly toolchain to a fixed date#60
nh13 merged 1 commit into
mainfrom
ci/pin-fmt-nightly

Conversation

@nh13

@nh13 nh13 commented Jun 23, 2026

Copy link
Copy Markdown

The CI fmt check installs a floating nightly toolchain (dtolnay/rust-toolchain with toolchain: nightly), so whenever a new nightly rustfmt is released it silently reformats unchanged code and turns the fmt check red — on every open PR at once, regardless of what that PR changed.

This bit the repo twice in one day: it forced a reformat in #59 (an unrelated spectrum.rs hunk), and then turned the entire open Design-Z PR stack (#54#57) red on fmt the moment their branches were re-pushed, even though none of them touched the flagged code.

Pin the fmt toolchain to nightly-2026-06-22 — the exact version main and all current branches are formatted against — so fmt drift only ever happens on a deliberate bump of this one line, not on an upstream nightly release. The action itself stays pinned by commit hash as before; only the floating toolchain: value is fixed.

Bumping rustfmt in future is then a one-line, reviewable change (update the date, run cargo +nightly fmt, commit the reformat together) instead of a surprise red on unrelated PRs.

Summary by CodeRabbit

  • Chores
    • Standardized formatting checks to use a fixed Rust nightly version, making CI results more consistent and predictable.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8f8269db-5761-4179-8311-bc34b49497a5

📥 Commits

Reviewing files that changed from the base of the PR and between 4cc06b9 and 781ebad.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

Walkthrough

Pins the nightly Rust toolchain in CI from a floating nightly to nightly-2026-06-22 in both the toolchain install step and the cargo fmt invocation within .github/workflows/ci.yml.

Changes

Nightly Toolchain Pin

Layer / File(s) Summary
Nightly toolchain pin and fmt command
.github/workflows/ci.yml
toolchain: nightly replaced with toolchain: nightly-2026-06-22; cargo +nightly fmt updated to cargo +nightly-2026-06-22 fmt to match.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main CI change: pinning the rustfmt check to a fixed nightly date.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/pin-fmt-nightly

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

The fmt check installed a floating `nightly`, so a new nightly rustfmt
release would silently reformat unchanged code and turn every open PR's
fmt check red (observed across the open Design-Z PR stack). Pin to
nightly-2026-06-22 — the version the current tree is formatted against —
so fmt drift only happens on a deliberate bump of this line.
@nh13 nh13 force-pushed the ci/pin-fmt-nightly branch from 61235b3 to 781ebad Compare June 23, 2026 23:00
@nh13

nh13 commented Jun 24, 2026

Copy link
Copy Markdown
Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@nh13

nh13 commented Jun 24, 2026

Copy link
Copy Markdown
Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@nh13

nh13 commented Jun 24, 2026

Copy link
Copy Markdown
Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@nh13

nh13 commented Jun 24, 2026

Copy link
Copy Markdown
Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@nh13

nh13 commented Jun 24, 2026

Copy link
Copy Markdown
Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@nh13 nh13 merged commit 24faa70 into main Jun 24, 2026
4 checks passed
@nh13 nh13 deleted the ci/pin-fmt-nightly branch June 24, 2026 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant