Repository navigation
diam: deliver a close to a CloseNotify() caller that asks after it happened. - #270
Merged
Merged
Conversation
…ppened closeNotify() creates the notify channel lazily, and notifyClientGone() only closed it if it already existed, recording nothing otherwise. So when a connection closed before anyone had called CloseNotify(), a later call created a fresh channel that nothing would ever close, and the caller blocked forever. Record the close in notifyClientGone() whether or not anyone is listening, and have closeNotify() return an already-closed channel when the connection is already gone. TestCloseNotifyAfterClose fails without this change and passes with it. TestCloseNotifyBeforeClose is the control. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
shifeeq
changed the title
fiorix
added a commit
that referenced
this pull request
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closeNotify() creates the notify channel lazily, and notifyClientGone() only closed it if it already existed, recording nothing otherwise. So when a connection closed before anyone had called CloseNotify(), a later call created a fresh channel that nothing would ever close, and the caller blocked forever.
Record the close in notifyClientGone() whether or not anyone is listening, and have closeNotify() return an already-closed channel when the connection is already gone.
TestCloseNotifyAfterClose fails without this change and passes with it. TestCloseNotifyBeforeClose is the control.