Skip to content

Upgrade JUnit 4 to 4.13.2 to resolve CVE-2020-15250 #1878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AustinBenoit wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Upgrade JUnit 4 to 4.13.2 to resolve CVE-2020-15250 #1878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion scripts/gha/integration_testing/gameloop_android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ dependencies {
implementation 'androidx.appcompat:appcompat:1.1.0'
implementation 'androidx.constraintlayout:constraintlayout:1.1.3'

androidTestImplementation 'androidx.test.ext:junit:1.1.1'
// 1.1.5 is used instead of newer versions (e.g. 1.3.0) to maintain compatibility
// with the project's older Kotlin (1.3.72) and Gradle (7.4.2) versions.
androidTestImplementation 'androidx.test.ext:junit:1.1.5'
androidTestImplementation 'androidx.test.espresso:espresso-core:3.2.0'
androidTestImplementation 'androidx.test.uiautomator:uiautomator:2.2.0'
}
6 changes: 4 additions & 2 deletions scripts/gha/ui_testing/uitest_android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,10 @@ android {
dependencies {
implementation fileTree(dir: "libs", include: ["*.jar"])
implementation 'androidx.appcompat:appcompat:1.1.0'
testImplementation 'junit:junit:4.12'
androidTestImplementation 'androidx.test.ext:junit:1.1.1'
testImplementation 'junit:junit:4.13.2'
// 1.1.5 is used instead of newer versions (e.g. 1.3.0) to maintain compatibility
// with the project's older Kotlin and Gradle versions.
Comment on lines +44 to +45

@gemini-code-assist gemini-code-assist Bot Jun 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The uitest_android module does not use Kotlin (it only applies the com.android.application plugin and contains Java test files). Mentioning Kotlin in this comment is inaccurate. Please update the comment to only refer to the Gradle version compatibility.

    // 1.1.5 is used instead of newer versions (e.g. 1.3.0) to maintain compatibility
    // with the project's older Gradle version.

@AustinBenoit AustinBenoit Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok but like transitively this due to the kotlin version. I think flagging that we upgrade kotlin / gradle we can move past this.

androidTestImplementation 'androidx.test.ext:junit:1.1.5'
androidTestImplementation 'androidx.test.espresso:espresso-core:3.2.0'
androidTestImplementation 'androidx.test:runner:' + rootProject.runnerVersion
androidTestImplementation 'androidx.test.uiautomator:uiautomator:' + rootProject.uiautomatorVersion
Expand Down
Loading