Skip to content

Fix the rest of the zizmor findings#1879

Merged
morganchen12 merged 2 commits into
mainfrom
mc/zizmor
Jul 1, 2026
Merged

Fix the rest of the zizmor findings#1879
morganchen12 merged 2 commits into
mainfrom
mc/zizmor

Conversation

@morganchen12

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@morganchen12 morganchen12 added the skip-release-notes Skip release notes check label Jul 1, 2026
@morganchen12 morganchen12 changed the title add ignores for C++ to appease the scanner Fix the rest of the zizmor findings Jul 1, 2026
@morganchen12 morganchen12 merged commit 2669482 into main Jul 1, 2026
42 of 67 checks passed
@morganchen12 morganchen12 deleted the mc/zizmor branch July 1, 2026 23:16
@github-actions github-actions Bot added the tests: in-progress This PR's integration tests are in progress. label Jul 1, 2026
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

Integration test with FLAKINESS (succeeded after retry)

Requested by @morganchen12 on commit 2669482
Last updated: Wed Jul 1 18:26 PDT 2026
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  CRASH/TIMEOUT
[TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
functions [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  CRASH/TIMEOUT
installations [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  CRASH/TIMEOUT
messaging [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions Bot added the tests: succeeded This PR's integration tests succeeded. label Jul 2, 2026
@firebase-workflow-trigger firebase-workflow-trigger Bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants