Conversation
A revision of the CI artifacts is uploaded one architecture at a time, and within an architecture the kernels land before the rootfs. The old code picked a revision by finding the newest object whose key contained "vmlinux" across all architectures, and download_ci_artifacts() then appended the host architecture to it and synced. So as soon as the aarch64 half of a new revision appeared, x86_64 jobs selected that revision too, synced an empty directory, and setup-ci-artifacts.sh died globbing *.squashfs. Filtering by architecture alone would not be enough, because a revision whose kernels have uploaded but whose rootfs has not would pass such a check and still leave the glob empty. Require a rootfs for both architectures before accepting a revision. Until a new revision has fully uploaded, every job keeps using the previous one, so a CI run tests against the same artifacts no matter which host each job lands on. Fail loudly if no revision qualifies, instead of returning a path that cannot be used. Signed-off-by: Ilias Stamatis <ilstam@amazon.com>
ilstam
force-pushed
the
fix-newest-s3-artifacts
branch
from
September 1, 2026 13:49
65a90db to
44fd9cf
Compare
ilstam
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6173 +/- ##
=======================================
Coverage 83.06% 83.06%
=======================================
Files 277 277
Lines 31019 31019
=======================================
Hits 25767 25767
Misses 5252 5252
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ilstam
added
the
Status: Awaiting review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A revision of the CI artifacts is uploaded one architecture at a time, and within an architecture the kernels land before the rootfs. The old code picked a revision by finding the newest object whose key contained "vmlinux" across all architectures, and download_ci_artifacts() then appended the host architecture to it and synced. So as soon as the aarch64 half of a new revision appeared, x86_64 jobs selected that revision too, synced an empty directory, and setup-ci-artifacts.sh died globbing *.squashfs.
Filtering by architecture alone would not be enough, because a revision whose kernels have uploaded but whose rootfs has not would pass such a check and still leave the glob empty.
Require a rootfs for both architectures before accepting a revision. Until a new revision has fully uploaded, every job keeps using the previous one, so a CI run tests against the same artifacts no matter which host each job lands on. Fail loudly if no revision qualifies, instead of returning a path that cannot be used.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.