Skip to content

[pciehp 4/4] Document PCIe hotplug auto-discovery - #6229

Open
ilstam wants to merge 2 commits into
ilstam-hotplug-3from
ilstam-hotplug-4
Open

ilstam wants to merge 2 commits into
ilstam-hotplug-3from
ilstam-hotplug-4

Conversation

@ilstam

@ilstam ilstam commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

This PR updates the PCIe hotplugging documentation (now that Firecracker support hotplug auto-discovery) and the CHANGELOG.

@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.88517% with 59 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (ilstam-hotplug-3@e174e38). Learn more about missing BASE report.

⚠️ Current head 5c3afa4 differs from pull request most recent head 769ab2c

Please upload reports for the commit 769ab2c to get more accurate results.

Files with missing lines Patch % Lines
src/vmm/src/lib.rs 46.66% 16 Missing ⚠️
src/vmm/src/builder.rs 84.52% 13 Missing ⚠️
src/vmm/src/device_manager/mod.rs 85.48% 9 Missing ⚠️
src/firecracker/src/api_server/parsed_request.rs 0.00% 6 Missing ⚠️
src/firecracker/src/api_server_adapter.rs 0.00% 3 Missing ⚠️
src/firecracker/src/main.rs 0.00% 3 Missing ⚠️
src/vmm/src/devices/pci/pci_segment.rs 93.02% 3 Missing ⚠️
src/vmm/src/rpc_interface.rs 33.33% 2 Missing ⚠️
src/vmm/src/devices/pci/root_port.rs 98.33% 1 Missing ⚠️
.../vmm/src/devices/virtio/block/vhost_user/device.rs 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@                 Coverage Diff                 @@
##             ilstam-hotplug-3    #6229   +/-   ##
===================================================
  Coverage                    ?   82.84%           
===================================================
  Files                       ?      243           
  Lines                       ?    28275           
  Branches                    ?        0           
===================================================
  Hits                        ?    23425           
  Misses                      ?     4850           
  Partials                    ?        0           
Flag Coverage Δ
6.1-m6a.metal 82.84% <85.88%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ilstam ilstam changed the title [pciehp 4/4] Document PCIe hot-plug auto-discovery [pciehp 4/4] Document PCIe hotplug auto-discovery Sep 17, 2026
@ilstam
ilstam added this pull request to stack #6230 September 17, 2026 17:16
@ilstam
ilstam marked this pull request as ready for review September 17, 2026 17:16
Now that Firecracker supports auto-discovery of hot-plugged devices
amend the documentation to explain how the feature works.

Signed-off-by: Ilias Stamatis <ilstam@amazon.com>
Add a new bullet point drawing attention to the new hotplug
auto-discovery feature.

Signed-off-by: Ilias Stamatis <ilstam@amazon.com>
Comment thread CHANGELOG.md

### Added

- [#6150](https://github.com/firecracker-microvm/firecracker/pull/6150),

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6150 was placeholder and needs to be replaced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant