[feat] ensure conversion hooks#790
Open
Fkuloff wants to merge 1 commit into
Open
Conversation
Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com> (cherry picked from commit 04ede3b)
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Forward-ports the "ensure conversion hooks" feature to
main. It shipped torelease-1.21in #783 but is missing onmain; this bringsmainin line. Cherry-pick (-x) of04ede3b— applied conflict-free on currentmain(3-way auto-merge),go build ./...andgo vetpass.What this PR does / why we need it
Adds a
module-ensure-hookstask that applies a module'sConversionWebhookresources before its Helm release, and wires it into the module converge lifecycle (module_manager,converge-modules, task service,task.go). This lets the cluster's webhook-handler patch the target CRDs'spec.conversionbefore the module creates custom resources that need converting — otherwise the API server stores those resources before conversion is live and prunes the old-version fields.Special notes for your reviewer
Straight forward-port of #783; no changes beyond the conflict-free cherry-pick onto
main. Original author: Stepan Paksashvili.