Add STACKIT tests - #652
Conversation
|
I am not sure how to get the image ID i set with |
@robinschneider to provide the image ID to the // cmd/kola/options.go
sv(&kola.STACKITOptions.ImageID, "stackit-image-id", "", "STACKIT image ID to deploy")Then from the // platform/api/stackit/api.go
type API struct {
...
opts *Options
}
type Options struct {
*platform.Options
...
}
func (a *API) CreateServer(ctx context.Context, name iaas.CreateServerPayloadGetNameAttributeType, networkId iaas.CreateServerNetworkingGetNetworkIdAttributeType, keypairName iaas.CreateServerPayloadGetKeypairNameAttributeType, userData iaas.CreateServerPayloadGetUserDataAttributeType) (*Server, error) {
...
ID := a.opts.ImageID |
tormath1
left a comment
There was a problem hiding this comment.
Thanks a lot, that's impressive: diving into Mantle codebase is not something easy, most of the comments are questions / nit-picks.
You might need to vendor the STACKIT dependencies go mod vendor.
tormath1
left a comment
There was a problem hiding this comment.
Thanks a lot for this huge contribution.
tormath1
left a comment
There was a problem hiding this comment.
This has been tested for ARM64 and AMD64. Thanks for the additional fixes. For the record, we still see some random error 500 with IP deletion but this does not impact the CI run for now, the IP is actually deleted (at least we don't see it on the portal) and can be revisited later.
Feel free to rebase on main to fix a small dependency conflict and squash all your commits. Thanks again!
Signed-off-by: Robin Schneider <robin.schneider@stackit.cloud>
Tests for new provider STACKIT
Add tests for new provider STACKIT
STACKIT now has it's own oem image and does not yet have any tests.
How to use
make vendor && make build./bin/ore stackit create-image --stackit-service-account-key-path "/home/ubuntu/.stackit/credentials.json" --stackit-project-id $STACKIT_PROJECT_ID -d./bin/kola spawn --platform stackit --stackit-service-account-key-path "/home/ubuntu/.stackit/credentials.json" --stackit-project-id $STACKIT_PROJECT_ID --stackit-image $STACKIT_IMAGE_ID -dTesting done
This is a work in progress PR and does not yet fully work
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.