Skip to content

platform/local/tpm: create swtpm socket in temp directory under /tmp #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhijianli88 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

platform/local/tpm: create swtpm socket in temp directory under /tmp #860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 7 additions & 15 deletions platform/local/tpm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,23 +13,16 @@ import (
type SoftwareTPM struct {
process *exec.ExecCmd
dirFromKolaCwd string
dirFromTestDir string
}

func NewSwtpm(testDir string, tpmDir string) (*SoftwareTPM, error) {
dirFromKolaCwd := filepath.Join(testDir, tpmDir)
swtpm := &SoftwareTPM{dirFromKolaCwd: dirFromKolaCwd, dirFromTestDir: tpmDir}

if err := os.Mkdir(swtpm.dirFromKolaCwd, 0700); err != nil {
return nil, fmt.Errorf("Failed to create TPM dir: %v", err)
dirFromKolaCwd, err := os.MkdirTemp("", "mantle-tpm-")
if err != nil {
return nil, fmt.Errorf("Failed to create TPM temp dir: %v", err)
}
swtpm := &SoftwareTPM{dirFromKolaCwd: dirFromKolaCwd}

swtpm.process = exec.Command("swtpm", "socket", "--tpmstate", fmt.Sprintf("dir=./%v", swtpm.dirFromTestDir), "--ctrl", fmt.Sprintf("type=unixio,path=./%v", swtpm.SocketRelativePathFromTestDir()), "--tpm2")
// Use the test directory as current working directory
// so that we don't have a socket path argument that
// exceeds 108 chars which is the limit for UNIX sockets
// (Using ./ as prefix helps to know that these are relative
// path arguments).
swtpm.process = exec.Command("swtpm", "socket", "--tpmstate", fmt.Sprintf("dir=%v", swtpm.dirFromKolaCwd), "--ctrl", fmt.Sprintf("type=unixio,path=%v", swtpm.SocketPath()), "--tpm2")
swtpm.process.Dir = testDir
plog.Debugf("Prepared swtpm process %q with CWD %q", swtpm.process, swtpm.process.Dir)
out, err := swtpm.process.StderrPipe()
Expand All @@ -55,7 +48,6 @@ func (swtpm *SoftwareTPM) Stop() {
os.RemoveAll(swtpm.dirFromKolaCwd)
}

func (swtpm *SoftwareTPM) SocketRelativePathFromTestDir() string {
const socket string = "socket"
return filepath.Join(swtpm.dirFromTestDir, socket)
func (swtpm *SoftwareTPM) SocketPath() string {
return filepath.Join(swtpm.dirFromKolaCwd, "socket")
}
2 changes: 1 addition & 1 deletion platform/machine/qemu/cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ ExecStartPost=/usr/bin/ln -fs /run/metadata/flatcar /run/metadata/coreos
if err != nil {
return nil, fmt.Errorf("starting swtpm: %v", err)
}
options.SoftwareTPMSocket = swtpm.SocketRelativePathFromTestDir()
options.SoftwareTPMSocket = swtpm.SocketPath()
defer func() {
if swtpm != nil {
swtpm.Stop()
Expand Down
2 changes: 1 addition & 1 deletion platform/machine/unprivqemu/cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ LinkLocalAddressing=no
if err != nil {
return nil, fmt.Errorf("starting swtpm: %v", err)
}
options.SoftwareTPMSocket = swtpm.SocketRelativePathFromTestDir()
options.SoftwareTPMSocket = swtpm.SocketPath()
defer func() {
if swtpm != nil {
swtpm.Stop()
Expand Down