platform/api/aws: remove redundant error return from CreateTags - #921
Open
vishnu2ko5 wants to merge 1 commit into
Open
platform/api/aws: remove redundant error return from CreateTags#921vishnu2ko5 wants to merge 1 commit into
vishnu2ko5 wants to merge 1 commit into
Conversation
Signed-off-by: MrCode-2005 <vishnusajeev2005@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
platform/api/aws: remove redundant error return from CreateTags
In
platform/api/aws/ec2.go, theCreateTagsfunction checks if the error from the API call is non-nil and returns early with a wrapped error. However, at the very end of the function, it returnserragain instead ofnil. This is redundant (sinceerris guaranteed to benilat that point) and makes the code slightly confusing.This PR updates the final return statement to return
nildirectly, making the intent clearer and avoiding potential bugs if code is ever added between the error check and the return statement in the future.How to use
Review the code diff to confirm that the logic remains functionally identical, but is clearer to read.
Testing done
Audited the code manually and verified that the success path correctly returns a
nilerror without altering the failure path behavior.changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.