Skip to content

github: Fix PR command dispatcher logic so it doesn't always trigger - #3491

Merged
chewi merged 1 commit into
mainfrom
chewi/gha-pr-command-logic
Nov 14, 2025
Merged

github: Fix PR command dispatcher logic so it doesn't always trigger#3491
chewi merged 1 commit into
mainfrom
chewi/gha-pr-command-logic

Conversation

@chewi

@chewi chewi commented Nov 14, 2025

Copy link
Copy Markdown
Contributor

github: Fix PR command dispatcher logic

In particular, it would leave a "Build action triggered" comment when closing a PR with a comment. This is the fix Copilot suggested. I'm not 100% sure it's right, but it probably doesn't make it any worse.

How to use

Close a PR with a comment (after merging).

Testing done

None... yet.

Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
@chewi chewi self-assigned this Nov 14, 2025
@chewi
chewi requested a review from a team as a code owner November 14, 2025 10:30

@krnowak krnowak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks ok, let's see if it does the trick.

@chewi
chewi merged commit 34de824 into main Nov 14, 2025
4 of 5 checks passed
@chewi
chewi deleted the chewi/gha-pr-command-logic branch November 14, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants