Skip to content

EDM-4859: Better align the Catalog content to the page#748

Open
celdrake wants to merge 1 commit into
flightctl:mainfrom
celdrake:EDM-4859-catalog-sidebar
Open

EDM-4859: Better align the Catalog content to the page#748
celdrake wants to merge 1 commit into
flightctl:mainfrom
celdrake:EDM-4859-catalog-sidebar

Conversation

@celdrake

@celdrake celdrake commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Make the content for Catalog consistent with the rest of the pages. The outer wrapping element does not use full-height unless the content requires so.

See comparison with Image Builds page, and how the Catalog would look like for fewer or more catalog items.

With fewer items:
with-few

With many items:
with-many

  • Updated the shared Catalog UI in libs/ui-components/ to use the default PageSection layout instead of the wizard layout, improving content height and page alignment.
  • Catalog rendering, filters, empty states, and split-pane behavior remain unchanged.
  • No changes to libs/types/, libs/i18n/, libs/cypress/, platform-specific apps, auth proxy, packaging, or CI.
  • As a shared component change, the updated layout may affect both standalone and OCP plugin consumers.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 565e8434-da0a-4c2f-a9bc-c5c3be89c8b0

📥 Commits

Reviewing files that changed from the base of the PR and between d586f35 and 524b0a4.

📒 Files selected for processing (1)
  • libs/ui-components/src/components/Catalog/CatalogPage.tsx

Walkthrough

The main catalog list section no longer uses the wizard-typed PageSection; its surrounding layout, filters, empty state, and catalog rendering remain unchanged.

Changes

Catalog layout

Layer / File(s) Summary
Default catalog section layout
libs/ui-components/src/components/Catalog/CatalogPage.tsx
The non-landing catalog branch removes type="wizard" from the main PageSection, leaving catalog content and surrounding layout logic unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested labels: ui-components

Suggested reviewers: rawagner, jkilzi

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the layout alignment change to Catalog content and is specific enough for a quick scan.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets ✅ Passed No hardcoded secrets or credential literals were found; the change is a UI prop removal in CatalogPage with only non-sensitive string/path literals.
No-Weak-Crypto ✅ Passed Only change removes a PageSection prop in CatalogPage.tsx; no weak crypto, custom crypto, or secret comparisons appear in the diff.
No-Injection-Vectors ✅ Passed Changed CatalogPage only removes a PageSection prop; no eval/exec, dangerouslySetInnerHTML, or yaml.load patterns appear in the touched Catalog subtree.
Container-Privileges ✅ Passed Only a UI TSX file changed; no container/K8s manifests or privilege settings (privileged, hostPID, hostNetwork, hostIPC, allowPrivilegeEscalation, SYS_ADMIN, root) were introduced.
No-Sensitive-Data-In-Logs ✅ Passed The PR only removes PageSection type="wizard"; no new logging, debug output, or sensitive-data exposure was added in the changed code.
Resource-Leaks ✅ Passed The PR changes only libs/ui-components TSX; no Go files under proxy/ were modified, so the resource-leaks check is not applicable.
Unchecked-Errors ✅ Passed PR only changes a TSX file; no Go files under proxy/ were modified, so the unchecked-error rule is not applicable.
Ai-Attribution ✅ Passed PASS: The PR commit includes "Made-with: Cursor" attribution, and the only Co-authored-by trailer is for dependabot, not AI.
Generated-Files-Not-Hand-Edited ✅ Passed Only CatalogPage.tsx changed; no files under libs/types/** or translation.json were edited.
I18n-Compliance ✅ Passed PASS: the change is layout-only; no new visible strings were added, and existing t() calls use hardcoded literals.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.


Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant