Skip to content

zstd: add 100 MB decompression size limit #11854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edsiper merged 2 commits into from
Jun 2, 2026
+17 −1
Merged

zstd: add 100 MB decompression size limit #11854

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7ec32a
zstd: add 100 MB decompression size limit
TristanInSec May 26, 2026
5ec1a83
zstd: cap buffer at max instead of aborting on overshoot
May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/flb_zstd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ struct flb_zstd_decompression_context {
ZSTD_DCtx *dctx;
};

#define FLB_ZSTD_DEFAULT_CHUNK 64 * 1024 /* 64 KB buffer */
#define FLB_ZSTD_DEFAULT_CHUNK (64 * 1024) /* 64 KB buffer */
#define FLB_ZSTD_DECOMPRESS_MAX (100 * 1024 * 1024) /* 100 MB limit */

int flb_zstd_compress(void *in_data, size_t in_len, void **out_data, size_t *out_len)
{
Expand Down Expand Up @@ -104,7 +105,16 @@ static int zstd_uncompress_unknown_size(void *in_data, size_t in_len, void **out

/* check if we need more space */
if (output.pos == out_size) {
if (out_size >= FLB_ZSTD_DECOMPRESS_MAX) {
flb_error("[zstd] maximum decompression size reached (~100 MB)");
flb_free(buf);
ZSTD_freeDCtx(dctx);
return -1;
}
out_size *= 2;
if (out_size > FLB_ZSTD_DECOMPRESS_MAX) {
out_size = FLB_ZSTD_DECOMPRESS_MAX;
}
tmp = flb_realloc(buf, out_size);
if (!tmp) {
flb_errno();
Expand Down Expand Up @@ -146,6 +156,12 @@ int flb_zstd_uncompress(void *in_data, size_t in_len, void **out_data, size_t *o
return ret;
}

if (size > FLB_ZSTD_DECOMPRESS_MAX) {
flb_error("[zstd] maximum decompression size is %d bytes",
FLB_ZSTD_DECOMPRESS_MAX);
return -1;
}

buf = flb_malloc(size);
if (!buf) {
flb_errno();
Expand Down
Loading