-
Notifications
You must be signed in to change notification settings - Fork 1.9k
out_s3: add format=parquet with selectable page compression codecs #11885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rituparnakhaund
wants to merge
3
commits into
fluent:master
Choose a base branch
from
rituparnakhaund:out_s3-parquet-format-compression-split
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+396
−75
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,6 +28,12 @@ | |
| #define FLB_AWS_COMPRESS_ZSTD 4 | ||
| #define FLB_AWS_COMPRESS_SNAPPY 5 | ||
|
|
||
| /* Parquet page-level compression codecs */ | ||
| #define FLB_PARQUET_COMPRESSION_NONE 0 | ||
| #define FLB_PARQUET_COMPRESSION_SNAPPY 1 | ||
| #define FLB_PARQUET_COMPRESSION_GZIP 2 | ||
| #define FLB_PARQUET_COMPRESSION_ZSTD 3 | ||
|
|
||
| /* | ||
| * Get compression type from compression keyword. The return value is used to identify | ||
| * what compression option to utilize. | ||
|
|
@@ -63,4 +69,13 @@ int flb_aws_compression_b64_truncate_compress(int compression_type, size_t max_o | |
| void *in_data, size_t in_len, | ||
| void **out_data, size_t *out_len); | ||
|
|
||
| /* | ||
| * Convert JSON data to Apache Parquet format with the specified | ||
| * page-level compression codec (FLB_PARQUET_COMPRESSION_*). | ||
| * Returns 0 on success, -1 on failure. | ||
| */ | ||
| int out_s3_compress_parquet(void *json, size_t size, | ||
| void **out_buf, size_t *out_size, | ||
| int parquet_compression); | ||
|
Comment on lines
+77
to
+79
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If we accept that we can apply compression on top of the existing formats then this method may not be needed long term |
||
|
|
||
| #endif | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am less sure on introducing parquet/arrow specific compression constants. We are migrating to parquet/arrow being formats that can have compression applied on top.