Skip to content

Add notation to TestAlluxioFIleUtils_ReportMetrics #5971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
121212123ws-maker wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add notation to TestAlluxioFIleUtils_ReportMetrics #5971

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/ddc/alluxio/operations/base_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,7 +581,9 @@ func TestAlluxioFileUtils_GetFileCount(t *testing.T) {
t.Errorf("check failure, want 6367897, got %d", fileCount)
}
}

// TestAlluxioFIleUtils_ReportMetrics tests the ReportMetrics method of AlluxioFileUtils.

@gemini-code-assist gemini-code-assist Bot Jun 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a typo in the comment: TestAlluxioFIleUtils_ReportMetrics contains a capitalized I (FIleUtils instead of FileUtils). Please correct this typo in the comment, and consider also renaming the test function TestAlluxioFIleUtils_ReportMetrics on line 587 to TestAlluxioFileUtils_ReportMetrics to maintain consistency and correct spelling.

Suggested change
// TestAlluxioFIleUtils_ReportMetrics tests the ReportMetrics method of AlluxioFileUtils.
// TestAlluxioFileUtils_ReportMetrics tests the ReportMetrics method of AlluxioFileUtils.

// This test verifies both the error handling when the underlying command execution fails
// and the successful path when the command returns valid cluster metrics information.
func TestAlluxioFIleUtils_ReportMetrics(t *testing.T) {
ExecCommon := func(a AlluxioFileUtils, command []string, verbose bool) (stdout string, stderr string, err error) {
return "report [category] [category args]\nReport Alluxio running cluster information.\n", "", nil
Expand Down