Skip to content

fix(dump): correct format string arguments for goroutine dump filename #5986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sukuna0007Abhi wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −11
Open

fix(dump): correct format string arguments for goroutine dump filename #5986

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca7d619
fix(dump): correct format string arguments for goroutine dump filename
Sukuna0007Abhi Jun 12, 2026
a30fdf2
Merge branch 'fluid-cloudnative:master' into fix-dump-filename-bug
Sukuna0007Abhi Jun 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/dump/dump.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ func InstallgoroutineDumpGenerator() {
timestamp := fmt.Sprint(t.Format("20060102150405"))
log.Info("User uses kill -3 to generate goroutine dump")
dumpfileMutex.RLock()
filename := fmt.Sprintf(dumpfile, "/tmp", "go", timestamp)
filename := fmt.Sprintf(dumpfile, "/tmp/go", timestamp)
dumpfileMutex.RUnlock()
coredump(filename)
default:
Expand Down
11 changes: 1 addition & 10 deletions pkg/dump/dump_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,13 +250,9 @@ func formatDumpfile(prefix, timestamp string) string {
}

// Helper function to find dump files in /tmp
// Updated to match the actual filename pattern based on the code bug
func findDumpFile() (string, bool) {
// Due to the bug in the code, the actual pattern is /tmp-go.txt
// because fmt.Sprintf("%s-%s.txt", "/tmp", "go", timestamp) only uses first 2 args
patterns := []string{
"/tmp-go.txt", // What the buggy code actually creates
"/tmp/go-*.txt", // What it should create
"/tmp/go-*.txt",
}

for _, pattern := range patterns {
Expand All @@ -276,7 +272,6 @@ func findDumpFile() (string, bool) {
// Helper function to clean up dump files
func cleanupDumpFiles() {
patterns := []string{
"/tmp-go.txt", // What the buggy code actually creates
"/tmp/go-*.txt",
"/tmp/test_coredump*.txt",
"/tmp/go-test-signal.txt",
Expand All @@ -299,9 +294,5 @@ func cleanupDumpFiles() {
if strings.HasPrefix(name, "test_coredump") {
_ = os.Remove(filepath.Join("/tmp", name))
}
// Also check for the buggy pattern
if name == "tmp-go.txt" {
_ = os.Remove(filepath.Join("/tmp", name))
}
}
}
Loading