Skip to content

This PR is to add comments to GetFuseMetricsScrapeTarget in pkg/ddc/base/runtime.go. #5988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cheyang merged 2 commits into from
Jun 17, 2026
+2 −0
Merged

This PR is to add comments to GetFuseMetricsScrapeTarget in pkg/ddc/base/runtime.go. #5988

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b834d17
Add comments to GetFuseMetricsScrapeTarget in pkg/ddc/base/runtime.go.
Summitnju Jun 13, 2026
d6d2add
Restore blank line before GetFuseMetricsScrapeTarget comment.
Summitnju Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/ddc/base/runtime.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,8 @@ func WithClientMetrics(clientMetrics datav1alpha1.ClientMetrics) RuntimeInfoOpti
return nil
}
}

// GetFuseMetricsScrapeTarget returns the configured metrics scrape target for the Fuse client.
Comment thread
Summitnju marked this conversation as resolved.
// The returned selector indicates which mount modes should expose Fuse metrics for scraping.
func (info *RuntimeInfo) GetFuseMetricsScrapeTarget() mountModeSelector {
return info.fuse.MetricsScrapeTarget
}
Comment on lines +314 to 318
Expand Down