Skip to content

fix: validate devtoolsOptionsUri in extensionEnabledState handler #9834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kenzieschmoll merged 7 commits into from
Jul 2, 2026
Merged

fix: validate devtoolsOptionsUri in extensionEnabledState handler #9834

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5bf2e38
fix: validate devtoolsOptionsUri scheme and filename in extensionEnab…
adilburaksen May 16, 2026
1fe700f
fix: restrict devtools_options.yaml path check to exact filename
adilburaksen May 16, 2026
a9e77d1
Harden devtoolsOptionsUri validation for Windows file URIs
adilburaksen Jun 5, 2026
0cb4a32
test: cover devtoolsOptionsUri validation in extensionEnabledState
adilburaksen Jun 9, 2026
0abdd91
Merge branch 'master' into fix/extension-enabled-state-path-validation
kenzieschmoll Jun 15, 2026
4bdad86
Fix test isolation in extensionEnabledState test and add release note
adilburaksen Jun 22, 2026
d12b431
Merge master and resolve NEXT_RELEASE_NOTES.md conflict
adilburaksen Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/devtools_shared/lib/src/server/handlers/_devtools_extensions.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,19 @@ extension _ExtensionsApiHandler on Never {
final devtoolsOptionsFileUriString =
queryParams[ExtensionsApi.devtoolsOptionsUriPropertyName]!;
final devtoolsOptionsFileUri = Uri.parse(devtoolsOptionsFileUriString);

// Validate that the URI is a local file URI pointing to a
// 'devtools_options.yaml' file. Accepting arbitrary URIs from the query
// string would allow an untrusted caller to create or overwrite any file
// writable by the DevTools server process.
if (devtoolsOptionsFileUri.scheme != 'file' ||
!devtoolsOptionsFileUri.path.endsWith('/devtools_options.yaml')) {

@kenzieschmoll kenzieschmoll Jun 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this forward slash work with windows file schemes?

return api.badRequest(
'Invalid devtoolsOptionsUri: must be a file: URI ending in '
"'devtools_options.yaml'.",
);
}

final extensionName = queryParams[ExtensionsApi.extensionNamePropertyName]!;

final activate = queryParams[ExtensionsApi.enabledStatePropertyName];
Expand Down