-
Notifications
You must be signed in to change notification settings - Fork 399
Check Dart formatting in all packages and in tool/ #9873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -13,13 +13,25 @@ if [ "$PACKAGE" = "devtools_app_shared" ]; then | |||||||
|
|
||||||||
| pushd $DEVTOOLS_DIR/packages/devtools_app_shared | ||||||||
| echo `pwd` | ||||||||
|
|
||||||||
| echo "Checking formatting..." | ||||||||
| # Here, we use the dart instance from the flutter SDK. | ||||||||
| $(dirname $(which flutter))/dart format --output=none --set-exit-if-changed . | ||||||||
|
srawlins marked this conversation as resolved.
Outdated
|
||||||||
|
|
||||||||
| flutter test test/ | ||||||||
| popd | ||||||||
|
|
||||||||
| elif [ "$PACKAGE" = "devtools_extensions" ]; then | ||||||||
|
|
||||||||
| pushd $DEVTOOLS_DIR/packages/devtools_extensions | ||||||||
| echo `pwd` | ||||||||
|
|
||||||||
| echo "Checking formatting..." | ||||||||
| # Here, we use the dart instance from the flutter SDK. | ||||||||
| $(dirname $(which flutter))/dart format --output=none --set-exit-if-changed . | ||||||||
|
srawlins marked this conversation as resolved.
Outdated
|
||||||||
|
|
||||||||
| # Note that this will _not_ test any tests in nested directories, if we add | ||||||||
| # any. | ||||||||
|
Comment on lines
+33
to
+34
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. hmm this seems like a bug? why aren't we running flutter test test/
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure. I can fix it in a separate PR. |
||||||||
| flutter test test/*_test.dart | ||||||||
| # Skip this on Windows because `flutter test --platform chrome` | ||||||||
| # appears to hang there. | ||||||||
|
|
@@ -33,6 +45,11 @@ elif [ "$PACKAGE" = "devtools_shared" ]; then | |||||||
|
|
||||||||
| pushd $DEVTOOLS_DIR/packages/devtools_shared | ||||||||
| echo `pwd` | ||||||||
|
|
||||||||
| echo "Checking formatting..." | ||||||||
| # Here, we use the dart instance from the flutter SDK. | ||||||||
| $(dirname $(which flutter))/dart format --output=none --set-exit-if-changed . | ||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [CONCERN] Running
Suggested change
|
||||||||
|
|
||||||||
| dart test test/ | ||||||||
| popd | ||||||||
|
|
||||||||
|
|
||||||||
Uh oh!
There was an error while loading. Please reload this page.