devtools_shared - allow tests to be run with "flutter test"#9874
Closed
srawlins wants to merge 1 commit into
Closed
devtools_shared - allow tests to be run with "flutter test"#9874srawlins wants to merge 1 commit into
srawlins wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a dartVMPath helper in packages/devtools_shared to resolve the Dart VM executable path, particularly when running under flutter_tester. It updates several test files to use dartVMPath instead of Platform.resolvedExecutable. Feedback was provided to make the dartVMPath resolution more robust by checking the FLUTTER_ROOT environment variable first and improving the fallback behavior when the SDK is not found.
kenzieschmoll
left a comment
kenzieschmoll
left a comment
Member
There was a problem hiding this comment.
Since this isn't a flutter package, tests shouldn't be ran with flutter test. The correct workflow is just to run devtools_shared/ tests with dart test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
packages/devtools_shared/, I couldn't run tests withflutter test(I assumed it was a flutter-dependent package).Gemini came up with this to fix the situation. If this is straight-up not a supported workflow, we don't have to land this. But it seems like a good change to me. Just promoting correctness.