Fix/formkit memory leak - #242
Open
filiphazardous wants to merge 2 commits into
Open
Conversation
The added test case in memory.spec.ts reproduces a memory leak.
|
@filiphazardous is attempting to deploy a commit to the Formkit Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #180
I work in a large code base using FormKit, and in a big table (with a sticky header, a sticky left column, sorting, free text search, and data cards in modals) we trigger the bug as described pretty easily.
I have one commit adding a test, and one commit with the fix. The test is modeled on the behavior of
@formkit/addons.AI usage disclosure:
I used Github copilot CLI to help diagnose, and write the tests (which I edited somewhat for clarity). After having the problem pointed out to me, I wrote the fix and verified with the test.
I can answer any question you may have about the fix. If you want me to fix it some other way, I am open to suggestions.
I posted a question about whether there is interest in a PR in the support-forum on Discord:
https://discord.com/channels/793529058377072650/1545415305659027456/1545415305659027456
(Also, not that it should matter, but my employer is an enterprise customer.)
Cheers!