fix: remove duplicate wrong error log in socket/fetch and dead code in reliablePing#370
Open
immanuwell wants to merge 1 commit into
Conversation
…d code in reliablePing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Contribution License Agreement
By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.
Description
Two small bugs fixed:
1. Wrong log message in
newt/socket/fetchhandler (main.go)After
client.SendMessage("newt/socket/containers", ...)there were two back-to-backif err != nilchecks on the same var. The first one had a copy-pasted message from a different handler:"Failed to send registration message"-- totally wrong context. On any send error you'd see that bogus line logged first, then the correct one right after. Dropped the duplicate stale block, kept the one with the right message.2. Dead code in
reliablePing(common.go)successCountstarts at 0 and is only incremented once before theif successCount > 0guard -- so that condition is always true when reached. The function always returned there, making everything after the loop unreachable. Removed the always-true guard and the dead post-loop code, left the behavior identical.How to test?
Bug 1 -- check the
newt/socket/fetchhandler inmain.go. With the old code, any error fromclient.SendMessagewould log"Failed to send registration message"(wrong) followed by"Failed to send Docker container list"(right). Now only the correct line fires.Bug 2 -- static analysis or a quick read:
successCount++immediately beforeif successCount > 0guarantees the condition, making the post-loopif successCount == 0branch and finalreturnunreachable. Behavior is unchanged, code is just honest now.