Repository navigation
fix(dashboard): paginate delivery attempt history - #2891
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delivery details previously stopped at the newest ten attempts even when the delivery had retried twenty times. Add cursor pagination and automatic loading as users scroll through the attempts sidebar, preserving the selected attempt and keeping the sidebar height bounded.
Pagination is opt-in (
paginated=trueandbefore), preserving the existing array response for API consumers. Pages use(created_at, id)ordering, include older embedded history, and retain header redaction and delivery ownership checks. Failed loads keep the current history visible and offer a retry. A load button remains available for keyboard users and browsers without automatic loading support.Validation: delivery-attempt and response-model Go tests, 12 focused dashboard tests, Go vet, lint, and generated API spec validation. Regression coverage includes exactly 20 attempts, timestamp ties, new retries between pages, foreign cursors, deleted records, embedded history, and observer cleanup/error handling.
Fixes #2890.