Repository navigation
fix(dashboard): expand delivery attempts sidebar to full viewport height before scrolling - #2893
Merged
Merged
Conversation
Contributor
Author
|
Hi, I've signed the CLA. Could you please approve the workflow runs so the checks can start? Thanks! |
vicenteyu
force-pushed
the
fix-delivery-attempts-sidebar
branch
from
October 22, 2026 03:11
19aa1d7 to
3e7e35e
Compare
Collaborator
Yes, approved |
mekilis
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the Delivery Attempts detail page, the left sidebar (delivery attempts list) has a fixed
max-h-[520px]constraint — it shows a scrollbar even when there's plenty of empty space below it. This means users see fewer attempt records at once and have to scroll more than necessary, while the right side of the page extends much further down.The sidebar should use the full available vertical space (matching the right content area height) and only show a scrollbar when the list actually exceeds that height.
Solution
Replace the fixed
max-h-[520px]with a relative/absolute layout pattern. The outer container usesrelativewithcontain: sizeto establish the height boundary, and the inner list usesabsolute inset-0to fill that space. This way the sidebar naturally grows to match the right panel's height, and scrolling only kicks in when content overflows.Code Changes
Before:
After:
Before
max-h-[520px]After
Screenshots
Before — sidebar is short, scrolls with empty space below:

After — sidebar uses full height, scrolls only when needed:
