refactor: fix running state theme and add pulse dot to status badges (TODO 1.2)#11
Open
Hemil-Sangani wants to merge 2 commits into
Open
refactor: fix running state theme and add pulse dot to status badges (TODO 1.2)#11Hemil-Sangani wants to merge 2 commits into
Hemil-Sangani wants to merge 2 commits into
Conversation
Member
|
use frappe-ui defaults? |
Contributor
Author
@rmehta Sir, currently I'm not using the frappe-ui default Badge — if needed I can switch to it |
Member
|
Always use default Frappe UI components |
Hemil-Sangani
force-pushed
the
refactor/status-badge-component
branch
from
8fb3dec to
da89c16
Compare
Contributor
Author
@rmehta Sir, updated the code to use the default frappe-ui Badge component. |
rmehta
requested changes
May 31, 2026
Member
rmehta
left a comment
rmehta
left a comment
There was a problem hiding this comment.
i don't get the point of this? why not just use the standard frappe-ui badge?
Hemil-Sangani
force-pushed
the
refactor/status-badge-component
branch
from
e5c56b2 to
83867f1
Compare
Hemil-Sangani
force-pushed
the
refactor/status-badge-component
branch
from
83867f1 to
e084977
Compare
Hemil-Sangani
changed the title
Hemil-Sangani
changed the title
Contributor
Author
|
@rmehta Sir, I’ve replaced the custom StatusBadge with frappe-ui Badge throughout. The only small addition is a .pulse-dot utility in index.css and an inline #prefix slot for the running state. No wrapper component anymore — please take a look when you get a chance. |
Hemil-Sangani
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements TODO 1.2 – Status Badges, standardising status indicators across the admin UI to use
frappe-ui Badgedirectly.Also introduces a small pulse-dot indicator for running/live states using the Badge
#prefixslot.Changes
index.css.pulse-dotutility using Tailwindanimate-pingProcesses.vuerunningtheme fromgreen→blue#prefixslot for running state itemsTaskDetail.vuestopped: redtoTASK_COLORmapbluethemeTaskList.vuestopped: redtoTASK_COLORmapprefixslotTheme Mapping