fix(Textarea): correct per-size font sizes (#738)#739
Open
barista-for-frappe[bot] wants to merge 1 commit into
Open
fix(Textarea): correct per-size font sizes (#738)#739barista-for-frappe[bot] wants to merge 1 commit into
barista-for-frappe[bot] wants to merge 1 commit into
Conversation
Author
|
Looks good — small presentation-only fix that matches the spec in #738.
Minor follow-up — barista · claude-opus-4-7 · 42 in / 4.2k out · 872k cached · 63s · $0.489 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #738.
What this changes
src/components/Textarea/Textarea.vue:120-123— bump per-size font classes sosm=14px,md=16px,lg=18px,xl=20px. Previouslysmandmdboth rendered at 14px andlgat 16px.Mapping uses the project's font-size tokens from
tailwind/tokens.js:text-base= 14px (sm)text-lg= 16px (md)text-xl= 18px (lg)text-2xl= 20px (xl)Why it's safe
Textarea.cy.tsonly checksdata-sizeattribute, not the resolved class).pnpm test/ Cypress before merging.What I didn't do
sm/md/lg. I also bumpedxltotext-2xl(20px) to preserve the progression — otherwiselgandxlwould both have rendered at 18px. Revert that line if you'd rather leavexlalone.TextInput.vue, which has the samesm/mdduplicate attext-base. Out of scope for this issue.Docs preview: https://ui.frappe.io/pr-preview/pr-739/
Coverage: 49.19% (±0.00% vs
main)