Vasty improve linting performance

.gitignore

@@ -33,4 +33,6 @@ bun.lock
 */build/*
 
 # IntelliJ
-.idea
+.idea
+.eslintcache
+tsconfig.tsbuildinfo

.husky/pre-push

@@ -1 +1,7 @@
-pnpm typecheck --minimumFailingSeverity warning
+if git diff --name-only @{u}..HEAD | grep -q '\.astro$'; then
+    echo "Running full astro check"
+    astro check --minimumFailingSeverity warning
+else
+    echo "Running TypeScript check"
+    tsc --noEmit
+fi

.remarkrc.mjs

@@ -12,19 +12,22 @@ export default {
         remarkPresetLintRecommended,
         remarkNoInlineCodeFences,
         remarkNoHtmlLinks,
-        [
-            remarkLintNoDeadUrls,
-            {
-                skipLocalhost: false,
-                skipOffline: true,
-                skipUrlPatterns: [
-                    'https://github.com/signup',
-                    'https://code.visualstudio.com/',
-                    'https://www.conventionalcommits.org/en/v1.0.0/',
-                    'https://vale.sh/',
-                    'https://squoosh.app/',
-                ], // Add known flaky URL patterns here
-            },
-        ],
+        // only run dead link checker in CI to save time in dev
+        process.env.CI
+            ? [
+                  remarkLintNoDeadUrls,
+                  {
+                      skipLocalhost: false,
+                      skipOffline: true,
+                      skipUrlPatterns: [
+                          'https://github.com/signup',
+                          'https://code.visualstudio.com/',
+                          'https://www.conventionalcommits.org/en/v1.0.0/',
+                          'https://vale.sh/',
+                          'https://squoosh.app/',
+                      ], // Add known flaky URL patterns here
+                  },
+              ]
+            : () => undefined,
     ],
 };

eslint.config.mjs

@@ -1,7 +1,6 @@
 import js from '@eslint/js';
 import astro from 'eslint-plugin-astro';
 import globals from 'globals';
-import process from 'node:process';
 import tseslint from 'typescript-eslint';
 
 import { defineConfig } from 'eslint/config';
@@ -21,8 +20,7 @@ export default defineConfig([
                 { argsIgnorePattern: '^_' },
             ],
             '@typescript-eslint/no-explicit-any': 'error',
-            // ci runs `astro check` which runs a full typescript checker
-            'no-undef': process.env.CI ? 'off' : 'error',
+            'no-undef': 'off',
         },
     },
     {
@@ -42,8 +40,5 @@ export default defineConfig([
                 ImageMetadata: 'readonly',
             },
         },
-        rules: {
-            'no-undef': 'off',
-        },
     },
 ]);

lint-staged.config.mjs

@@ -1,6 +1,25 @@
+const runPrettierOn =
+    '**/*.{' +
+    [
+        'js',
+        'mjs',
+        'ts',
+        'json',
+        'json5',
+        'jsonc',
+        'css',
+        'md',
+        'mdx',
+        'yaml',
+        'yml',
+        'astro',
+    ].join(',') +
+    '}';
+
 /** @type {import('lint-staged').Configuration} */
 export default {
-    '**/*': (files) => `prettier --write --ignore-unknown ${files.join(' ')}`,
+    [runPrettierOn]: (files) =>
+        `prettier --write --ignore-unknown ${files.join(' ')}`,
     '**/*.{astro,ts,mjs,js}': (files) => `eslint --fix ${files.join(' ')}`,
     'src/content/**/*.{md,mdx}': (files) => [
         `pnpm remark ${files.join(' ')} --ext mdx --frail --no-stdout --quiet`,

package.json

@@ -17,7 +17,7 @@
         "prebuild": "tsx scripts/generate-glossary.ts",
         "predev": "tsx scripts/generate-glossary.ts",
         "lint": "pnpm lint:eslint && pnpm lint:md && pnpm lint:regions && pnpm lint:glossary && pnpm typecheck && pnpm vale",
-        "lint:eslint": "eslint .",
+        "lint:eslint": "eslint \"src/**/*.{ts,astro,js,mjs,css}\" \"*.mjs\" \"scripts/*.{ts,mjs,js}\" --cache",
         "lint:md": "remark src/content/docs --ext mdx --frail",
         "lint:regions": "tsx scripts/validate-regions.ts",
         "vale": "pnpm vale:setup && vale sync && vale src/content",
@@ -42,6 +42,7 @@
         "@eslint/js": "^10.0.1",
         "@types/estree": "^1.0.9",
         "@types/mdast": "^4.0.4",
+        "@types/node": "^26.1.2",
         "@vvago/vale": "^3.16.0",
         "astro-eslint-parser": "^1.4.0",
         "eslint": "^10.5.0",

scripts/validate-regions.ts

@@ -1,10 +1,11 @@
 import { readFileSync, readdirSync } from 'fs';
-import { join, relative } from 'path';
+import { basename, join, relative } from 'path';
 import { fileURLToPath } from 'url';
 
 const ROOT = fileURLToPath(new URL('..', import.meta.url));
 const EXAMPLES_DIR = join(ROOT, 'examples');
 const DOCS_DIR = join(ROOT, 'src', 'content', 'docs');
+const SKIP_DIRS = new Set(['build', '.gradle', 'node_modules', 'gradle']);
 
 const START_RE = /^\s*(?:\/\/|#|--|<!--|-->)?\s*\[(\w+)\]\s*$/;
 const END_RE = /^\s*(?:\/\/|#|--|<!--|-->)?\s*\[\/(\w+)\]\s*$/;
@@ -15,6 +16,7 @@ const CODE_REGION_SOURCES_KEY_RE = /^codeRegionSources:\s*$/;
 const CODE_REGION_SOURCE_ENTRY_RE = /^\s+([\w-]+):\s*(.+?)\s*$/;
 
 const errors: string[] = [];
+const extensions: Set<string> = new Set();
 
 function parseCodeRegionSources(content: string): Map<string, string> {
     const sources = new Map<string, string>();
@@ -35,9 +37,9 @@ function parseCodeRegionSources(content: string): Map<string, string> {
         const m = line.match(CODE_REGION_SOURCE_ENTRY_RE);
         if (m) {
             sources.set(m[1]!, m[2]!);
+            extensions.add(m[2]!.split('.').at(-1)!);
         }
     }
-
     return sources;
 }
 
@@ -63,7 +65,7 @@ function walkMdx(dir: string) {
                 if (!m) continue;
 
                 const [, alias, definedFilePath, regionName] = m;
-
+                console.dir(m);
                 let filePath: string | undefined;
                 if (alias) {
                     filePath = codeRegionSources.get(alias);
@@ -74,6 +76,14 @@ function walkMdx(dir: string) {
                         continue;
                     }
                 } else if (definedFilePath) {
+                    const ext = basename(definedFilePath).split('.').at(-1);
+                    if (!ext) {
+                        errors.push(
+                            `${relative(DOCS_DIR, full)}: Region "${regionName}" doesn't specify a file extension.`,
+                        );
+                        continue;
+                    }
+                    extensions.add(ext);
                     filePath = definedFilePath;
                 } else {
                     filePath = codeRegionSources.get('default');
@@ -147,11 +157,18 @@ function validateSource(filePath: string) {
 }
 
 function walkExamples(dir: string) {
+    if (SKIP_DIRS.has(basename(dir))) {
+        return;
+    }
     for (const entry of readdirSync(dir, { withFileTypes: true })) {
         const full = join(dir, entry.name);
         if (entry.isDirectory()) {
             walkExamples(full);
         } else {
+            if (!extensions.has(full.split('.').at(-1)!)) {
+                // we only care about source files
+                continue;
+            }
             validateSource(full);
         }
     }

tsconfig.json

@@ -3,9 +3,11 @@
     "include": [".astro/types.d.ts", "**/*"],
     "exclude": ["dist"],
     "compilerOptions": {
+        "lib": ["DOM", "ESNext"],
         "paths": {
             "@components/*": ["./src/components/*"]
         },
-        "checkJs": true
+        "checkJs": true,
+        "incremental": true
     }
 }