Added wecanhelp as a new provider to the enum. #163#170
Conversation
Signed-off-by: Yash Sarnobat <yashsarnobat.31@gmail.com>
YashSarnobat
force-pushed
the
added_wecanhelp
branch
from
dc96d1c to
6365035
Compare
| "enum": ["", "betterplace", "wecanhelp"], | ||
| "default": "", | ||
| "deprecated": true, | ||
| "deprecatedDescription": "This provider is deprecated and will be removed in a future version." |
There was a problem hiding this comment.
with that you would deprecate the whole field, not just a single entry
| "description": "Where do you host your donations?", | ||
| "enum": [ "", "betterplace", "boost" ], | ||
| "default": "" | ||
| "enum": ["", "betterplace", "wecanhelp"], |
There was a problem hiding this comment.
please leave boost in there, some communities and tools will have these values still set.
So we have a chance to migrate and remove boost later
There was a problem hiding this comment.
please leave boost in there, some communities and tools will have these values still set.
So we have a chance to migrate and remove boost later
I have made the requested changes, please review and let me know if this fixes it!
There was a problem hiding this comment.
please leave boost in there, some communities and tools will have these values still set.
So we have a chance to migrate and remove boost laterI have made the requested changes , please review and let me know if this fixes it!
PR: #174
2 participants
Marked boost as "depricated" and added "wecanhelp" as a new provider to the enum.