tasks(security): pre-PR gates — threat-actor / no-irreversible-bundle / source-layer-first#31
Open
havardljohansen wants to merge 1 commit into
Open
Conversation
… / source-layer-first Closes havardljohansen/dev-cockpit#71. Tightens find-security-issues with three gates that must hold before any security PR opens. Anti-example for all three: frontkom/merkur-frontend#334 (2026-06-15) bundled a sanitizeHref() defense-in-depth pass with HSTS preload without naming the threat-actor; the editor-trust case eliminated the threat for the project, HSTS doesn't bundle with anything reversible, and Sanity schema URL validators were the one-line source-layer fix. Version bump 2026-06-10b → 2026-06-15a per AGENTS.md (tasks/ counts as framework-level change). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tightens
tasks/find-security-issues.mdwith three pre-PR gates afterfrontkom/merkur-frontend#334(2026-06-15) closed as misfit.Gates
javascript:URI in CMS hrefs below their threat floor — skip.Rule.uri, Drupal validators, ACF constraints, Shopify metafield validation — if the source can enforce, the runtime patch is a bandage.Anti-example:
#334sanitizeHref()defense-in-depth (1-commit-revert)Version bump
2026-06-10b→2026-06-15aper AGENTS.md (tasks/ counts as framework-level).Refs
🤖 Generated with Claude Code