Repository navigation
test(images): record which machine ID read fails in the tally - #59
Merged
Merged
Conversation
Publication run 38062049493 failed only on Tumbleweed's tally, on machine_id. That check reads every machine's live ID, and the tallies before and after it passed, so one read failed transiently; the evidence recorded only whether the IDs were distinct, and could not say which. machine_id_tally now records each failed read's exit status, output length, stderr and duration, and the machines that share an ID. It never records an ID itself: machine IDs are confidential. The pass condition is unchanged, except that a read must also exit 0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Publication run 38062049493 failed acceptance on a single check: openSUSE Tumbleweed r6's
tally, onmachine_id. Everything else passed, including the three images from #58. Nothing was published.The failure looks transient:
machine_idcheck also reads every other machine's live/etc/machine-id. The tallies just before and after it passed, and both read Tumbleweed's machine too.uninitializedin its tree.The evidence recorded only
distinct_across_machines, so nobody could tell which machine's read failed, or how.machine_id_tally()is now a pure function, and its result records:failed_reads: for each read that exited non-zero or didn't return 32 characters, the exit status, output length, stderr tail and duration. It keeps the output only when it isn't an ID, such asuninitializedor an empty string.shared: the machines whose IDs collide.machines: how many machines were read.It never records a machine ID itself, since
machine-id(5)calls them confidential. The pass condition is unchanged, except that a read must now also exit 0.Publication results
The second commit records Phase 2 of the more-releases plan and updates the docs index and publication design:
debian:testing,fedora:rawhideandubuntu:24.04on an empty cache.Testing
scripts/test_probe_machines.pycovers distinct IDs, an ID in the image tree, failed reads (with no ID leaking into evidence) and a shared ID.probe-machines.py --only tallyon Debian 13 r6 and Ubuntu 24.04 r2 with VM image r10 passed, and the evidence carried the new fields.make cipasses.🤖 Generated with Claude Code