Repository navigation
fix(images): reject non-printable core Flatpak names - #1055
Merged
Merged
Conversation
Firn's wizard shows each core app's name on the installer console before the image is verified, so firn now treats names containing control or format characters as malformed. The producer must reject the same names, or snosi could publish a label every firn install refuses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
11 of 14 tasks
bketelsen
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keeps snosi's producer validation in step with frostyard/firn#111. Firn's wizard renders each core app's name on the installer console from an unverified preview inspection, so firn now treats names containing control or format characters (escape sequences, newlines, tabs, zero-width joiners) as malformed.
check_setnow rejects the same names, so snosi can't publish a label that every opted-in firn install refuses.str.isprintable()matches Go'sunicode.IsPrint, which firn uses: plain spaces and non-ASCII letters pass. Every published label today is plain ASCII, andvalidatepasses unchanged.Type of change
Validation
shellcheck/validate.ymlstatic checks pass for touched scriptstest/were runCommands run:
Checklist
🤖 Generated with Claude Code