Repository navigation
ci(deps): bump mise-action to v5.1.1 - #434
Merged
Merged
Conversation
github-actions
Bot
added
the
github_actions
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The dependency executes third-party code at a protected CI trust boundary and requires the requested maintainer security review.
Review effort: Balanced
Findings: None
What changed in this PR
Updates the CI lint job to use the latest stable jdx/mise-action v5 release, including cached-binary verification and safer token handling.
Changes:
- Pins
jdx/mise-actionv5.1.1 to its verified release SHA. - Retains existing tool installation and cache configuration.
| File | Description |
|---|---|
.github/workflows/test.yml |
Updates the pinned mise action used by the lint job. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bketelsen
enabled auto-merge
October 6, 2026 23:44
bsherman
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jdx/mise-actionto2d8d4cafcbd33be2ea37d2b6f5ad595363d1f1cawith the existing version-comment style. Verified the upstream release tag resolves directly to this commit and v5.1.1 descends from v5.0.1..github/workflows/test.yml). Includes the upstream cached-binary verification fix released in v5.0.1.Compatibility and recovery
v5 defaults to a 24-hour minimum age for an unpinned mise release; tool versions remain pinned in mise.toml/mise.lock. v5.1.1 no longer persists the action's GitHub token to later steps by default; the subsequent lint step does not need it, so no opt-in is added. Failed cached-binary verification triggers replacement by the action. No permissions, tool pins, product code, or release workflows changed.
Rollback: revert this one-line commit if CI reveals incompatibility; prefer a verified v5.0.1-or-newer pin rather than restoring v5.0.0. No installed-system migration is involved.
Risk classification
Tier 4: Critical, because
.github/workflows/**is a protected boundary under the repository risk guide. Explicit maintainer security review is requested before merge.Threat/abuse analysis: the trust boundary is third-party action execution and cached executable reuse on the CI runner. The immutable upstream release SHA preserves action provenance; the included upstream fix verifies cached mise before execution. The job retains
contents: read, checkout credential persistence remains disabled, and later steps no longer inherit the action token by default. This PR changes no security gates and does not implement new verification logic itself.Checks
mise exec go@1.26.6 -- make ci: tidy, vet, formatting, exact-pin lint, unit tests/coverage gate, E2E tests, race tests, Linux amd64/arm64 builds. IncludesTestWorkflowsPinActionsAndLeastPrivilege.node scripts/check-docs.mjsandgit diff --check.make ciattempt lacked Go; installed the toolchain and pinned tools using mise, then the full gate passed.Brian merges; no auto-merge requested.