fix(#3446): remove invalid top-level return guard from inlined CSMA code#3448
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
fix(#3446): remove invalid top-level return guard from inlined CSMA code#3448fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
The CSMA library load guard (`return 0` at top level) was left in when the library was inlined into post-prioritize.sh and its test file. Since these scripts are executed directly (not sourced), `return` at top level is invalid bash and crashes the script with exit code 2 when GITHUB_API_CSMA_SH_LOADED is set in the environment. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
E2E tests did not runE2E tests run automatically for org/repo members and collaborators on pull requests. For other contributors, a maintainer must add the See E2E testing guide for details. |
1 similar comment
E2E tests did not runE2E tests run automatically for org/repo members and collaborators on pull requests. For other contributors, a maintainer must add the See E2E testing guide for details. |
Site previewPreview: https://e83941bf-site.fullsend-ai.workers.dev Commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[[ -n "${GITHUB_API_CSMA_SH_LOADED:-}" ]] && return 0/GITHUB_API_CSMA_SH_LOADED=1) frompost-prioritize.shandpost-prioritize-test.shreturn: can only 'return' from a function or sourced script, exit code 2) whenGITHUB_API_CSMA_SH_LOADEDis set in the environmentCloses #3446
Test plan
GITHUB_API_CSMA_SH_LOADED=1 bash post-prioritize.shno longer crashes with areturnerror (exits with missing env var error instead, as expected)bash internal/scaffold/fullsend-repo/scripts/post-prioritize-test.sh🤖 Generated with Claude Code