Skip to content

chore: repository cleanup - #24

Merged
Maximus7474 merged 5 commits into
mainfrom
chore/repo-cleanup
Jul 3, 2026
Merged

Maximus7474 merged 5 commits into
mainfrom
chore/repo-cleanup

Conversation

@FjamZoo

@FjamZoo FjamZoo commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Description

Remove dead code, tighten exports, drop unused deps, and enforce consistent LF line endings. No behaviour changes; apps/resource is intentionally untouched.

  • Add .gitattributes enforcing LF (fixes CRLF-vs-LF Biome check failures)
  • Delete dead route barrel apps/core/src/routes/index.ts (unused; index.ts imports the route modules directly)
  • Remove commented-out mock-data blocks (dashboard playerList, use-resourcelist) and leftover debug console.log calls across webpanel pages
  • Drop the commented-out warnPlayer call / hardcode note in core
  • Drop redundant export on in-file-only symbols: LoginForm, NavItemNoItems, EmptyState, BAND_LABELS, Managers, ImportPlayerNote, ImportWhitelist
  • Remove two useless empty constructors (game/resource managers); replace {} as any with a typed Record in ConfigManager
  • Remove unused dependencies: ui (date-fns, zod, @tailwindcss/vite, @turbo/gen, globals), webpanel (globals)

Tests

  • Tested in development mode
  • Passes typecheck
  • Builds & runs on Windows
  • Builds & runs on Linux

Additional Notes

None of this is tested please wait for all other PRs to be merged then Ill upstream nd do final test(s)

Remove dead code, tighten exports, drop unused deps, and enforce
consistent LF line endings. No behaviour changes; apps/resource is
intentionally untouched.

- Add .gitattributes enforcing LF (fixes CRLF-vs-LF Biome check failures)
- Delete dead route barrel apps/core/src/routes/index.ts (unused;
  index.ts imports the route modules directly)
- Remove commented-out mock-data blocks (dashboard playerList,
  use-resourcelist) and leftover debug console.log calls across
  webpanel pages
- Drop the commented-out warnPlayer call / hardcode note in core
- Drop redundant `export` on in-file-only symbols: LoginForm,
  NavItemNoItems, EmptyState, BAND_LABELS, Managers, ImportPlayerNote,
  ImportWhitelist
- Remove two useless empty constructors (game/resource managers);
  replace `{} as any` with a typed Record in ConfigManager
- Remove unused dependencies: ui (date-fns, zod, @tailwindcss/vite,
  @turbo/gen, globals), webpanel (globals)
FjamZoo added 2 commits July 3, 2026 16:32
Follow-up cleanup after merging latest main:
- Delete unused apps/webpanel settings mock-settings.ts (dead mock data;
  superseded by types/settings.ts)
- Drop stray console.log(roles) in whitelist settings tab
- Drop commented-out alternative sendCommand impl in process manager
@FjamZoo
FjamZoo marked this pull request as ready for review July 3, 2026 14:48
@FjamZoo
FjamZoo requested review from Maximus7474 and andreutu and removed request for Maximus7474 and andreutu July 3, 2026 14:48

@Maximus7474 Maximus7474 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - nice'n clean

@Maximus7474
Maximus7474 merged commit fa61f8b into main Jul 3, 2026
5 checks passed
@FjamZoo
FjamZoo deleted the chore/repo-cleanup branch July 4, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants