Repository navigation
chore: repository cleanup - #24
Merged
Merged
Conversation
Remove dead code, tighten exports, drop unused deps, and enforce
consistent LF line endings. No behaviour changes; apps/resource is
intentionally untouched.
- Add .gitattributes enforcing LF (fixes CRLF-vs-LF Biome check failures)
- Delete dead route barrel apps/core/src/routes/index.ts (unused;
index.ts imports the route modules directly)
- Remove commented-out mock-data blocks (dashboard playerList,
use-resourcelist) and leftover debug console.log calls across
webpanel pages
- Drop the commented-out warnPlayer call / hardcode note in core
- Drop redundant `export` on in-file-only symbols: LoginForm,
NavItemNoItems, EmptyState, BAND_LABELS, Managers, ImportPlayerNote,
ImportWhitelist
- Remove two useless empty constructors (game/resource managers);
replace `{} as any` with a typed Record in ConfigManager
- Remove unused dependencies: ui (date-fns, zod, @tailwindcss/vite,
@turbo/gen, globals), webpanel (globals)
Maximus7474
marked this pull request as draft
June 29, 2026 17:54
Follow-up cleanup after merging latest main: - Delete unused apps/webpanel settings mock-settings.ts (dead mock data; superseded by types/settings.ts) - Drop stray console.log(roles) in whitelist settings tab - Drop commented-out alternative sendCommand impl in process manager
FjamZoo
marked this pull request as ready for review
July 3, 2026 14:48
FjamZoo
requested review from
Maximus7474 and
andreutu
and removed request for
Maximus7474 and
andreutu
July 3, 2026 14:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove dead code, tighten exports, drop unused deps, and enforce consistent LF line endings. No behaviour changes; apps/resource is intentionally untouched.
exporton in-file-only symbols: LoginForm, NavItemNoItems, EmptyState, BAND_LABELS, Managers, ImportPlayerNote, ImportWhitelist{} as anywith a typed Record in ConfigManagerTests
Additional Notes
None of this is tested please wait for all other PRs to be merged then Ill upstream nd do final test(s)