Repository navigation
[pull] main from bazel-contrib:main - #694
Merged
Merged
Conversation
…ty (#4008) Rename `abi_tag` to `soabi` in `PyCcToolchainInfo` and associated toolchain implementation and macro parameters. I found the `abi_tag` term a bit ambiguous with PEP 425 wheel ABI tags and PEP 3149 C extension filename SOABI tags. So rename it to `soabi` to directly reflect the SOABI sysconfig var that it is traditionally derived from. This also uncovered a bug where the value was _just_ the Python ABI-ness (`cpython-311`), while it should be the full ABI infix that includes the platform (`cpython-311-x86_64-linux-gnu`). This also helped simplify some of the Windows code paths.
Enable static type verification for the runfiles library using the rules_pyrefly ruleset. To ensure hermetic type safety across Bazel runfiles utilities, this configures rules_pyrefly's Bzlmod dev toolchain, tags the runfiles target with `tags = ["pyrefly"]`, and enables global aspect evaluation in .bazelrc via `--aspects=//tests/support/pyrefly:pyrefly.bzl%pyrefly_aspect`. To support WORKSPACE mode builds without breaking dependency resolution, a no-op stub repository for rules_pyrefly is defined under tests/modules/rules_pyrefly_stub and registered in internal_dev_deps.bzl. Under Bzlmod, the aspect performs static type checking on tagged targets, while under WORKSPACE mode, the stub aspect evaluates cleanly as a no-op.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )