Improve accuracy of colcon-test-result#172
Open
scpeters wants to merge 4 commits into
Open
Conversation
Add suffix to intermediate junit xml files to prevent colcon test-result from reading them as real test results. Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
Member
Author
|
to verify this fix, I cherry-picked on top of
|
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Helps with gazebosim/sdformat#1648
Summary
While experimenting with
action-ros-ciin gazebosim/sdformat#1648, I noticed thatcolcon test-resultincorrectly identifies a failed test in agz-toolsbuild folder even when tests haven't been run due to the.xmlsuffix of the intermediate${TEST_NAME}_fail.xmlfile (also known asUNIT_gz_TEST_fail.xml).Adding a suffix to the intermediate junit xml files prevents
colcon test-resultfrom reading them as real test results.To test:
gz-toolscolcon buildcolcon test-resultshould not show a failurecolcon test && colcon test-resultstill should not show the spurious failureChecklist
codecheckpassed (See contributing)Generated-by: Remove this if GenAI was not used.
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.Backports: If this is a backport, please use Rebase and Merge instead.