Skip to content

Unhide warning when schema test is skipped#1658

Open
scpeters wants to merge 2 commits into
mainfrom
scpeters/unhide_schema_test_skipped_warning
Open

Unhide warning when schema test is skipped#1658
scpeters wants to merge 2 commits into
mainfrom
scpeters/unhide_schema_test_skipped_warning

Conversation

@scpeters

Copy link
Copy Markdown
Member

🦟 Bug fix

Unhides a warning added in #1655

Summary

The schema integration test fails when run with very new versions of xmllint. This was discovered when adding CI with Ubuntu 26.04 in #1655, and logic to disable the test with a warning was added in that PR. Unfortunately, the warning is not currently being reported due to the order in which gz_build_warning is processed in gz_configure_build even though the test is skipped:

This unhides the warning by switching to message(WARNING ""), in a similar manner to gazebosim/gz-transport#565.

Checklist

  • Signed all commits for DCO
  • Added a screen capture or video to the PR description that demonstrates the fix (as needed)
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • Updated Bazel files (if adding new files). Created an issue otherwise.
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Backports: If this is a backport, please use Rebase and Merge instead.

Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
@scpeters

Copy link
Copy Markdown
Member Author

From Ubuntu Resolute CI:

  CMake Warning at test/integration/CMakeLists.txt:89 (message):
    xmllint version is too new (21502).  schema_test won't be run

@scpeters scpeters marked this pull request as ready for review May 12, 2026 20:54
@scpeters scpeters requested a review from azeey as a code owner May 12, 2026 20:54
set (tests ${tests} schema_test.cc)
else()
gz_build_warning("xmllint version is too new (${XMLLINT_VERSION}). schema_test won't be run")
message(WARNING "xmllint version is too new (${XMLLINT_VERSION}). schema_test won't be run")

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we want CI to ignore this as a warning, we can use message(STATUS instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

2 participants