Skip to content

macos CI: test on push to release branches only (backport #1672)#1680

Merged
scpeters merged 2 commits into
sdf12from
mergify/bp/sdf12/pr-1672
Jun 26, 2026
Merged

macos CI: test on push to release branches only (backport #1672)#1680
scpeters merged 2 commits into
sdf12from
mergify/bp/sdf12/pr-1672

Conversation

@mergify

@mergify mergify Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

🦟 Bug fix

Reduces macOS job triggering

Summary

Currently our GitHub workflow for macOS CI runs on every push to a branch, whereas our other CI workflows only run on pushes to release branches. This updates the macOS job triggering to match our Ubuntu CI triggering.

The impact of this change is to reduce the number of CI minutes used and to prevent triggering of duplicate CI jobs (from push and pull_request), potentially reducing the time spent waiting for CI to complete.

Backport Policy

  • This is safe to backport to the following versions:
    • Jetty
    • Ionic
    • Harmonic
    • Fortress
  • This should not be backported
  • I am not sure
  • Other (fill in yourself)

Checklist

  • Signed all commits for DCO
  • Added a screen capture or video to the PR description that demonstrates the fix (as needed)
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • Updated Bazel files (if adding new files). Created an issue otherwise.
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Backports: If this is a backport, please use Rebase and Merge instead.


This is an automatic backport of pull request #1672 done by [Mergify](https://mergify.com).

Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
(cherry picked from commit ed54622)
@mergify mergify Bot requested review from azeey and scpeters as code owners June 26, 2026 00:17
@github-actions github-actions Bot added the 🏯 fortress Ignition Fortress label Jun 26, 2026
@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.33%. Comparing base (5fab7a4) to head (4836515).
⚠️ Report is 16 commits behind head on sdf12.

Additional details and impacted files
@@            Coverage Diff             @@
##            sdf12    #1680      +/-   ##
==========================================
+ Coverage   92.14%   92.33%   +0.18%     
==========================================
  Files          79       79              
  Lines       13126    13893     +767     
==========================================
+ Hits        12095    12828     +733     
- Misses       1031     1065      +34     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scpeters

Copy link
Copy Markdown
Member

waiting on #1670

@github-project-automation github-project-automation Bot moved this from Inbox to In review in Core development Jun 26, 2026
@scpeters scpeters merged commit b0485d1 into sdf12 Jun 26, 2026
9 checks passed
@scpeters scpeters deleted the mergify/bp/sdf12/pr-1672 branch June 26, 2026 20:11
@github-project-automation github-project-automation Bot moved this from In review to Done in Core development Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏯 fortress Ignition Fortress

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants