Repository navigation
fix: return markdown lexicon errors - #139
Merged
Merged
Conversation
Signed-off-by: vansh-nagar <vansh.nagar.dev@gmail.com>
jmeridth
approved these changes
Oct 5, 2026
jmeridth
left a comment
jmeridth
left a comment
Member
There was a problem hiding this comment.
🤖 (summary) Approving. Routing the error through the template FuncMap is a clean way to do this: text/template stops execution when a func returns a non-nil error, and render already wraps and returns it, so the panic is gone without changing output for valid inputs. The regression test for the unknown-term path is a good addition. Thanks for picking up #45. (AI review, model: claude-opus-5-5.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45.
Replaces the unknown-term panic with an error and carries that error through the lexicon linker into Go templates, where rendering already returns execution errors. Adds a regression test for the unknown-term path and updates the linker tests for the error-returning signature.
Test:
go test ./gemaraconv/markdown/...