Skip to content

fix(tasks): stop spinner after provisioning error #2481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arnestrickmann merged 1 commit into from
Jun 15, 2026
+6 −18
Merged

fix(tasks): stop spinner after provisioning error #2481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions apps/emdash-desktop/src/renderer/features/sidebar/task-item.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,6 @@ export const SidebarTaskItem = observer(function SidebarTaskItem({
const task = getTaskStore(projectId, taskId)!;
const taskManager = getTaskManagerStore(projectId);

const isBootstrapping =
task.state === 'unregistered' ||
(task.state === 'unprovisioned' &&
(task.phase === 'provision' || task.phase === 'provision-error'));

const taskName = task.data.name;

const handleProvision = () => {
Expand Down Expand Up @@ -121,7 +116,7 @@ export const SidebarTaskItem = observer(function SidebarTaskItem({
<span
className={cn(
'min-w-0 truncate text-left transition-colors',
isBootstrapping && 'text-foreground/40'
task.isBootstrapping && 'text-foreground/40'
)}
>
{taskName}
Expand Down
11 changes: 2 additions & 9 deletions apps/emdash-desktop/src/renderer/features/sidebar/task-sidebar-agent-status.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,7 @@ import { observer } from 'mobx-react-lite';
import { AgentStatusIndicator } from '@renderer/features/tasks/components/agent-status-indicator';
import { CLISpinner } from '@renderer/features/tasks/components/cliSpinner';
import { taskAgentStatus } from '@renderer/features/tasks/stores/task-selectors';
import {
isUnprovisioned,
isUnregistered,
type TaskStore,
} from '@renderer/features/tasks/stores/task-store';
import { type TaskStore } from '@renderer/features/tasks/stores/task-store';
import { useDelayedBoolean } from '@renderer/lib/hooks/use-delay-boolean';
import { sidebarStore } from '@renderer/lib/stores/app-state';
import { RelativeTime } from '@renderer/lib/ui/relative-time';
Expand All @@ -31,10 +27,7 @@ export const TaskSidebarTrailingSlot = observer(function TaskSidebarTrailingSlot
task: TaskStore;
showTimestamp: boolean;
}) {
const isBootstrapping =
isUnregistered(task) ||
(isUnprovisioned(task) && (task.phase === 'provision' || task.phase === 'provision-error'));
const delayedIsBootstrapping = useDelayedBoolean(isBootstrapping, 500);
const delayedIsBootstrapping = useDelayedBoolean(task.isBootstrapping, 500);

if (delayedIsBootstrapping) {
return (
Expand Down
6 changes: 3 additions & 3 deletions apps/emdash-desktop/src/renderer/features/tasks/stores/task-store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,11 @@ export class TaskStore {
return this.data.name;
}

/** True only while creation/provisioning is actively running — error phases are settled, not busy. */
get isBootstrapping(): boolean {
return (
this.state === 'unregistered' ||
(this.state === 'unprovisioned' &&
(this.phase === 'provision' || this.phase === 'provision-error'))
(this.state === 'unregistered' && this.phase === 'creating') ||
(this.state === 'unprovisioned' && this.phase === 'provision')
);
}

Expand Down
Loading