Skip to content

add --zstd option for geode package new #2156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dankmeme01 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add --zstd option for geode package new #2156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions cmake/GeodeFile.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,13 @@ function(setup_geode_mod proname)
set(DONT_UPDATE_INDEX_ARG "")
endif()

# Zstd option for smaller .geode file sizes
if (GEODE_PACKAGE_ZSTD)
set(ZSTD_ARG "--zstd")
else()
set(ZSTD_ARG "")
endif()

# Check dependencies using CLI
if (${GEODE_CLI_VERSION} VERSION_GREATER_EQUAL "3.2.0")
execute_process(
Expand Down Expand Up @@ -183,7 +190,7 @@ function(setup_geode_mod proname)
COMMAND ${GEODE_CLI} package new ${CMAKE_CURRENT_SOURCE_DIR}
--binary $<TARGET_FILE:${proname}> $<TARGET_LINKER_FILE:${proname}> $<TARGET_PDB_FILE:${proname}>
--output ${CMAKE_CURRENT_BINARY_DIR}/${MOD_ID}.geode
${INSTALL_ARG} ${PDB_ARG}
${INSTALL_ARG} ${PDB_ARG} ${ZSTD_ARG}
VERBATIM USES_TERMINAL
)
else()
Expand All @@ -192,7 +199,7 @@ function(setup_geode_mod proname)
COMMAND ${GEODE_CLI} package new ${CMAKE_CURRENT_SOURCE_DIR}
--binary $<TARGET_FILE:${proname}> $<TARGET_PDB_FILE:${proname}>
--output ${CMAKE_CURRENT_BINARY_DIR}/${MOD_ID}.geode
${INSTALL_ARG} ${PDB_ARG}
${INSTALL_ARG} ${PDB_ARG} ${ZSTD_ARG}
VERBATIM USES_TERMINAL
)
endif()
Expand All @@ -203,7 +210,7 @@ function(setup_geode_mod proname)
COMMAND ${GEODE_CLI} package new ${CMAKE_CURRENT_SOURCE_DIR}
--binary $<TARGET_FILE:${proname}> $<TARGET_LINKER_FILE:${proname}>
--output ${CMAKE_CURRENT_BINARY_DIR}/${MOD_ID}.geode
${INSTALL_ARG}
${INSTALL_ARG} ${ZSTD_ARG}
VERBATIM USES_TERMINAL
)
else()
Expand All @@ -212,7 +219,7 @@ function(setup_geode_mod proname)
COMMAND ${GEODE_CLI} package new ${CMAKE_CURRENT_SOURCE_DIR}
--binary $<TARGET_FILE:${proname}>
--output ${CMAKE_CURRENT_BINARY_DIR}/${MOD_ID}.geode
${INSTALL_ARG}
${INSTALL_ARG} ${ZSTD_ARG}
VERBATIM USES_TERMINAL
)
endif()
Expand Down
Loading