pyvista scripts for compositional field visualizations#7006
Conversation
|
Thank you for all the work! Also, it turns out that there is already a YAML file which builds a conda environment for ASPECT, but it has some problems. I have opened an issue relating to that. For now, we can just create a YAML file which works for your scripts. I think that the one included in #6993 should work, but please feel free to make your own if you need to. If you do make your own YAML file please share it with me. |
| pad_inches=0.01, | ||
| facecolor="white" | ||
| ) | ||
| plt.close(fig) No newline at end of file |
There was a problem hiding this comment.
It looks like the end of this script is missing a newline at the end after line 130. You should be able to see a red symbol on github showing that a newline is missing. I think you can just hit enter in vscode at the end of the file to create a newline there.
|
|
||
| # save final figure | ||
| plt.savefig(output_png, dpi=300, bbox_inches="tight", pad_inches=0.01, facecolor="white") | ||
| plt.close(fig) No newline at end of file |
There was a problem hiding this comment.
A newline is also needed here
|
|
||
| # save final figure | ||
| plt.savefig(output_png, dpi=300, bbox_inches="tight", pad_inches=0.01, facecolor="white") | ||
| plt.close(fig) No newline at end of file |
There was a problem hiding this comment.
A newline is also needed here
There was a problem hiding this comment.
It looks like the color in this figure are different than the earlier time steps it gets much blacker at the edges. Did something change when making tis figure, or is it just because the range is changing.
There was a problem hiding this comment.
@mibillen The original figure is "zoom-in on the center" (Fig. 33 from documentation). Would it be better to change the figure to a zoomed in version or change the caption in the documentation (I would imagine that this would lessen confusion).
|
Hello, I talked to some of the ASPECT developers at the user meeting and their recommendation was to move the plotting scripts out of the doc directory so that they are easier to find. So moving the whole plotting_scripts directory up one level. I think after that is done it will probably be ready for a final review and to get merged. |
|
@bobmyhill Hello, I think this is ready to be reviewed whenever you get the chance. |
3 participants
adds python scripts to create the visualizations for the compositional field cookbooks (passive, active, active w/ reaction).
haven't added a YAML file to build conda environment