Skip to content

Tkc dc#43

Open
sgkang wants to merge 5 commits into
mainfrom
TKC_DC
Open

Tkc dc#43
sgkang wants to merge 5 commits into
mainfrom
TKC_DC

Conversation

@sgkang

@sgkang sgkang commented Jul 26, 2017

Copy link
Copy Markdown
Contributor

Revive TKC DC and IP

  • Merge scripts to notebooks
  • Break a part forward and inversion notebooks for both DC and IP.
  • Only works simpeg/dcip/spectralIP branch

@sgkang sgkang requested a review from lheagy July 26, 2017 00:41
@lheagy

lheagy commented Jul 26, 2017

Copy link
Copy Markdown
Member

Thanks for this Seogi! There are a couple issues I have come across in TKC_DC_fwd (I fixed a couple plt.show() statements to prevent duplicate plots with ipywidgets), but there are some more involved ones I could use your help with:
image
image

I am fairly sure that using

fig, ax = plt.subplots(1, 2)

is more stable than using add subplot. Would you mind replacing those?

(P.S. I am using matplotlib 4.3.23)

There are some similar things happening with the IP ones as well

image

@sgkang

sgkang commented Jul 27, 2017

Copy link
Copy Markdown
Contributor Author

thanks @lheagy I did not change using fig, ax = plt.subplots(1, 2),
but made some modifications due to plt.show() issue, and
it seems working for my end at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants