Skip to content

Codex/unify locale resolution#316

Open
n1n9-jp wants to merge 207 commits into
gephi:mainfrom
data-visualization-lectures:codex/unify-locale-resolution
Open

Codex/unify locale resolution#316
n1n9-jp wants to merge 207 commits into
gephi:mainfrom
data-visualization-lectures:codex/unify-locale-resolution

Conversation

@n1n9-jp

@n1n9-jp n1n9-jp commented Jun 28, 2026

Copy link
Copy Markdown

Pull request type

Check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

NOTE: Try to limit your pull request to one type, submit multiple pull requests if needed.

What is the current behavior?

Issue Number: N/A

NOTE: Describe the current behavior that you are modifying, or link to a relevant issue.

What is the new behavior?

NOTE: Describe the behavior or changes that are being added by this PR.

Other information

NOTE: Any other information that is important to this PR such as screenshots of how the component looks before and after the change.

n1n9-jp and others added 30 commits November 5, 2025 15:53
- Create api/github-proxy.ts for CORS-enabled GitHub proxy
- Configure vercel.json for Vercel deployment
- Supports REACT_APP_GITHUB_PROXY environment variable

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Update outputDirectory to packages/gephi-lite/build to match monorepo layout

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Env variables will be set directly in Vercel dashboard instead of using Secrets references

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Use npx to properly resolve preconstruct command during npm install in Vercel environment

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Use workspace-specific npm commands to avoid slow monorepo build

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Use npm ci with --ignore-scripts to avoid preconstruct delay during install phase

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Include npm install and preconstruct build in buildCommand to ensure proper dependency resolution

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
n1n9-jp and others added 29 commits March 28, 2026 23:57
provider フィールドが undefined の場合、JSON.parse が
'"undefined" is not valid JSON' というエラーを起こしていました。

修正内容:
- user/index.tsx: provider が存在しない場合、localStorage に含めない
- AuthInit.tsx: provider が存在しない場合のチェックを追加

これにより、provider が undefined でも安全にデシリアライズできるようになります。

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
「Loaded Project を読み込みました」という不自然なメッセージを
「プロジェクトを読み込みました」に修正しました。

背景:
- dataviz-tool-header API の onProjectLoad では projectData のみが渡される
- メタデータ(プロジェクト名など)が available でないため、
  ダミー値の「Loaded Project」を表示していた

修正内容:
- Initialize.tsx: 読込メッセージを簡潔に変更
- ToolHeaderConfig.tsx:
  * onProjectLoad メッセージを簡潔に
  * onProjectLoad エラーメッセージも日本語に統一

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
…-tool-header-hooks

[codex] Refactor tool header helpers and attribute hooks
@sim51

sim51 commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator

Hi,

First of all, thank you for your PR and for your interest in this project.

Unfortunately, your PR doesn't include a description. Could you explain its goal and what it is intended to achieve?

This PR is also extremely large (+65,169 / -8,937 lines across 210 commits), which makes it impossible for the team to review effectively. Could you please split it into multiple smaller PRs, each focused on a single feature or change? It would also help if each commit addressed a single logical change.

A few additional comments:

  • Please write commit messages and code comments in English.
  • The build directory should not be committed.
  • I noticed that .github/workflows/deploy-docker.yml was deleted. Was this intentional? If so, could you explain why?
  • You added a README_EN.md and replaced the main README.md with the Japanese version. We'd prefer to keep the English documentation as the default README.md.

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants