Skip to content

Page headings on rest of the pages - #1920

Merged
sadiqkhoja merged 2 commits into
getodk:features/table-redesignfrom
sadiqkhoja:table-redesign/page-headings-on-other-pages
Oct 2, 2026
Merged

sadiqkhoja merged 2 commits into
getodk:features/table-redesignfrom
sadiqkhoja:table-redesign/page-headings-on-other-pages

Conversation

@sadiqkhoja

Copy link
Copy Markdown
Contributor

dependent on #1905

@changeset-bot

changeset-bot Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 42a9caa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sadiqkhoja
sadiqkhoja force-pushed the table-redesign/page-headings-on-other-pages branch from 3988ac9 to 31bc360 Compare September 25, 2026 14:23
@sadiqkhoja
sadiqkhoja marked this pull request as ready for review September 25, 2026 14:38
@sadiqkhoja
sadiqkhoja force-pushed the table-redesign/page-headings-on-other-pages branch from 31bc360 to 15fcb05 Compare September 28, 2026 18:35
@sadiqkhoja
sadiqkhoja force-pushed the features/table-redesign branch from dd868e3 to e32bf46 Compare September 29, 2026 17:38
Comment on lines +11 to +13
<template v-if="helpText">{{ helpText }}</template>
<slot v-else name="help" :hide="hideHelp"></slot>
</div>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can simplify this by just using slot

Comment on lines 51 to 56
const { formVersions } = useRequestData();
return { formVersions };
const { form, formVersions } = useRequestData();
return { form, formVersions };
},

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undo this

-->
<template>
<div id="form-edit">
<page-heading v-if="form.dataExists" :title="$t('formHead.tab.editForm')"/>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove v-if="form.dataExists"

"en": {
"action": {
// This is the text of a button that is used to create a new Form.
"create": "New"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use @transifexkey

<i18n-t tag="p" keypath="heading[1].full">
<template #clickHere>
<doc-link to="central-submissions/#public-access-links">{{ $t('moreInfo.clickHere.clickHere') }}</doc-link>
<a href="#" @click.prevent="hide(); submissionOptions.show()">{{ $t('heading[1].clickHere') }}</a>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's create a method and pass hide function to it.

it('toggles the modal', () =>
load('/projects/1/forms/f/public-links').testModalToggles({
modal: PublicLinkCreate,
show: '.heading-with-button .btn-primary',

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove from app.scss if .heading-with-button is not used by any component.

@sadiqkhoja
sadiqkhoja force-pushed the table-redesign/page-headings-on-other-pages branch from 15fcb05 to f646a60 Compare October 2, 2026 16:21
@sadiqkhoja
sadiqkhoja merged commit ff8e8f3 into getodk:features/table-redesign Oct 2, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants